Skip to content

bpo-33166: Change os.cpu_count to return active (real) processors - #15949

Merged
zware merged 3 commits into
python:masterfrom
zooba:bpo-33166
Sep 11, 2019
Merged

bpo-33166: Change os.cpu_count to return active (real) processors#15949
zware merged 3 commits into
python:masterfrom
zooba:bpo-33166

Conversation

@zooba

@zoobazooba commented Sep 11, 2019•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@zoobazooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.8 labels Sep 11, 2019
@zooba

zooba commented Sep 11, 2019

Copy link
Copy Markdown
MemberAuthor

Note that I added the prototype rather than changing the Windows version in pyconfig.h. This is so it's safe to backport to 3.8.

In a later PR I'll update the API version.

zware
zware requested changes Sep 11, 2019
View reviewed changes
Comment threadModules/posixmodule.c
@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@zooba

zooba commented Sep 11, 2019

Copy link
Copy Markdown
MemberAuthor

I don't want to backport the WINNT_VER change because we have so much stuff that tries to auto-detect macros, and that may introduce new macros. It's a little late in the release cycle for that.

@zooba

zooba commented Sep 11, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again

Ping @zware

zware
zware approved these changes Sep 11, 2019
View reviewed changes

@zwarezware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoobazooba mentioned this pull request Sep 11, 2019
Merged
@zware
zware merged commit aa92927 into python:masterSep 11, 2019
@miss-islington

miss-islington commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@zooba@miss-islington
bpo-33166: Change os.cpu_count to return active (real) processors (py…
a9475d6
…thonGH-15949)
(cherry picked from commit aa92927)
Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

GH-15979 is a backport of this pull request to the 3.8 branch.

@zooba
zooba deleted the bpo-33166 branch September 11, 2019 15:16
miss-islington added a commit that referenced this pull request Sep 11, 2019
@miss-islington@zooba
bpo-33166: Change os.cpu_count to return active (real) processors (GH…
43ee0e2
…-15949)
(cherry picked from commit aa92927)
Co-authored-by: Steve Dower <steve.dower@python.org>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@zooba@DinoV
bpo-33166: Change os.cpu_count to return active (real) processors (py…
71dc9e0
…thonGH-15949)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwarezwarezware approved these changes

Assignees

No one assigned

Labels

OS-windowstype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba@bedevere-bot@miss-islington@zware@the-knights-who-say-ni