Skip to content

bpo-37330: open() no longer accept 'U' in file mode - #16959

Merged
vstinner merged 3 commits into
python:masterfrom
vstinner:remove_open_universal2
Oct 28, 2019
Merged

bpo-37330: open() no longer accept 'U' in file mode#16959
vstinner merged 3 commits into
python:masterfrom
vstinner:remove_open_universal2

Conversation

@vstinner

@vstinnervstinner commented Oct 27, 2019•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

open(), io.open(), codecs.open() and fileinput.FileInput no longer
accept "U" ("universal newline") in the file mode. This flag was
deprecated since Python 3.3.

test_fileinput: add tests for 'rU' and 'U' modes

Run make regen-all.

https://bugs.python.org/issue37330

@vstinner
bpo-37330: open() no longer accept 'U' in file mode
6d74ba5
open(), io.open(), codecs.open() and fileinput.FileInput no longer
accept "U" ("universal newline") in the file mode. This flag was
deprecated since Python 3.3.
test_fileinput: add tests for 'rU' and 'U' modes
Run make regen-all.
@vstinnervstinner mentioned this pull request Oct 27, 2019
Closed
@vstinner

vstinner commented Oct 27, 2019

Copy link
Copy Markdown
MemberAuthor

This is the rebased PR #14204 that I failed to reopen. docutils and Sphinx were updated: they no longer use open("U").

@serhiy-storchaka: You approved PR #14204, would you mind to approve this PR as well?

tirkarthi
tirkarthi approved these changes Oct 27, 2019
View reviewed changes

@tirkarthitirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems test_pty failure is tracked with https://bugs.python.org/issue38547. Thanks Victor.

serhiy-storchaka
serhiy-storchaka reviewed Oct 27, 2019
View reviewed changes
Comment threadLib/test/test_codecs.py
Comment threadLib/test/test_io.py Outdated
@vstinner

vstinner commented Oct 28, 2019

Copy link
Copy Markdown
MemberAuthor

@serhiy-storchaka: I added more tests, does it look good to you now?

serhiy-storchaka
serhiy-storchaka reviewed Oct 28, 2019
View reviewed changes
Comment threadLib/test/test_codecs.py Outdated
# "U" mode has been removed in Python 3.9
for mode in ("U", "rU", "r+U"):
with self.assertRaises(ValueError) as cm:
codecs.open(support.TESTFN, mode)

@serhiy-storchakaserhiy-storchakaOct 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass an encoding.

@vstinnervstinnerOct 28, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooh, the codecs module remains a mystery to me :-) Ok, I added an encoding and I added tests for "rt" mode.

@vstinner

vstinner commented Oct 28, 2019

Copy link
Copy Markdown
MemberAuthor

@serhiy-storchaka: Sorry, I misunderstood the codecs module for "rt" mode. Adding an encoding was the fix :-) I added more tests for this mode as well.

@vstinner
vstinner merged commit e471e72 into python:masterOct 28, 2019
@vstinner
vstinner deleted the remove_open_universal2 branch October 28, 2019 14:40
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vstinnerJake Taylor
bpo-37330: open() no longer accept 'U' in file mode (pythonGH-16959)
20a1dda
open(), io.open(), codecs.open() and fileinput.FileInput no longer
accept "U" ("universal newline") in the file mode. This flag was
deprecated since Python 3.3.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vstinner@shihai1991
bpo-37330: open() no longer accept 'U' in file mode (pythonGH-16959)
1bfd0ab
open(), io.open(), codecs.open() and fileinput.FileInput no longer
accept "U" ("universal newline") in the file mode. This flag was
deprecated since Python 3.3.
This was referenced Mar 1, 2020
Closed
Closed
Closed
Closed
Open
Closed
@vstinnervstinner mentioned this pull request Mar 3, 2020
Merged
vstinner added a commit that referenced this pull request Mar 4, 2020
@vstinner
bpo-39674: Revert "bpo-37330: open() no longer accept 'U' in file mode (
942f7a2
GH-16959)" (GH-18767)
This reverts commit e471e72.
The mode will be removed from Python 3.10.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@tirkarthitirkarthitirkarthi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@serhiy-storchaka@tirkarthi@the-knights-who-say-ni@bedevere-bot