Skip to content

bpo-38823: Clean up refleaks in faulthandler initialization. - #17250

Merged
vstinner merged 3 commits into
python:masterfrom
brandtbucher:faulthandler
Nov 19, 2019
Merged

bpo-38823: Clean up refleaks in faulthandler initialization.#17250
vstinner merged 3 commits into
python:masterfrom
brandtbucher:faulthandler

Conversation

@brandtbucher

@brandtbucherbrandtbucher commented Nov 19, 2019•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@brandtbucherbrandtbucher added OS-windows skip news type-bug An unexpected behavior, bug, or error labels Nov 19, 2019
@brandtbucher

brandtbucher commented Nov 19, 2019

Copy link
Copy Markdown
MemberAuthor

@vstinner

vstinner
vstinner reviewed Nov 19, 2019
View reviewed changes
Comment threadModules/faulthandler.c Outdated
EXCEPTION_ACCESS_VIOLATION))
EXCEPTION_ACCESS_VIOLATION)) {
Py_DECREF(m);
return NULL;

@vstinnervstinnerNov 19, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, what do you think of adding a "error:" label which does the DECREF + return NULL?

@brandtbucherbrandtbucherNov 19, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer that. I just wanted to keep the diffs small for all of these.

Should I make the change?

@brandtbucherbrandtbucherNov 19, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

vstinner
vstinner reviewed Nov 19, 2019
View reviewed changes
Comment threadModules/faulthandler.c
@vstinner
vstinner merged commit ac22354 into python:masterNov 19, 2019
@vstinner

vstinner commented Nov 19, 2019

Copy link
Copy Markdown
Member

Thanks. I took the liberty of rewriting the commit message.

@miss-islington

miss-islington commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2019
@brandtbucher@miss-islington
bpo-38823: Fix refleaks in faulthandler init error path on Windows (p…
21c7bb4
…ythonGH-17250)
(cherry picked from commit ac22354)
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@bedevere-bot

bedevere-bot commented Nov 19, 2019

Copy link
Copy Markdown

GH-17263 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2019
@brandtbucher@miss-islington
bpo-38823: Fix refleaks in faulthandler init error path on Windows (p…
c67599f
…ythonGH-17250)
(cherry picked from commit ac22354)
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@bedevere-bot

bedevere-bot commented Nov 19, 2019

Copy link
Copy Markdown

GH-17264 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Nov 19, 2019
@miss-islington@brandtbucher
bpo-38823: Fix refleaks in faulthandler init error path on Windows (G…
5bd2af9
…H-17250)
(cherry picked from commit ac22354)
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
miss-islington added a commit that referenced this pull request Nov 19, 2019
@miss-islington@brandtbucher
bpo-38823: Fix refleaks in faulthandler init error path on Windows (G…
a5ed2fe
…H-17250)
(cherry picked from commit ac22354)
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@brandtbucherJake Taylor
bpo-38823: Fix refleaks in faulthandler init error path on Windows (p…
fa263f4
…ythonGH-17250)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@brandtbucher@shihai1991
bpo-38823: Fix refleaks in faulthandler init error path on Windows (p…
4083578
…ythonGH-17250)
@brandtbucher
brandtbucher deleted the faulthandler branch July 21, 2022 20:00
@brandtbucherbrandtbucher mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

Assignees

No one assigned

Labels

OS-windowsskip newstype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brandtbucher@vstinner@miss-islington@bedevere-bot@the-knights-who-say-ni