bpo-31711: On SSLObject.write method, added assert that data has content.

[choyos]

This avoid to rise ssl.SSLEOFError on petition that has no content on response.

https://bugs.python.org/issue31711

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@choyos

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

[raulcd]

Hi,
Thanks for your contribution. Why would you want to obscure this returning an emtpy string. To me raising an Exception sounds like the approach we should maintain. Can you elaborate more on the case of why this behaviour has to change?
Thanks
Raúl

[tiran]

if data:

[tiran]

write returns the number of bytes sent. The function should either return 0 or fail with a more useful exception.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[joernheissler]

To me raising an Exception sounds like the approach we should maintain. Can you elaborate more on the case of why this behaviour has to change?

See https://bugs.python.org/issue31711 for some discussion. Currently, the behaviour is undefined, i.e. instead of an exception something else may happen. Some code change is required to achieve defined behaviour, whichever that is.

I prefer a noop.

[slingamn]

Previous PR implementing no-op behavior: #7559

[choyos]

Sorry about the delay. I have made the requested changes as suggested by @tiran.
Also, I have looked #7559 indicated by @slingamn. Both solutions seem fine for me, but I think this change is less critical if the C function is used on other points, avoiding regressions.
If there was another solution to this problem, it would also be fine for me, but it needs to be solved.

[csabella]

@choyos, the bot could not find a signed CLA for you. Please take a look at the instructions above for setting that up.

[tiran]

Thanks to PEP 644 the issue will be fixed in 3.10 by using SSL_read_ex and SSL_write_ex() functions. I couldn't use the functions earlier because Python had to support older OpenSSL versions and LibreSSL. #25468