Skip to content

bpo-38870: Simplify tuple like interleaves, roundtrip extslice properly - #17892

Merged
pablogsal merged 1 commit into
python:masterfrom
isidentical:bpo-38870-ext-slice
Mar 9, 2020
Merged

bpo-38870: Simplify tuple like interleaves, roundtrip extslice properly#17892
pablogsal merged 1 commit into
python:masterfrom
isidentical:bpo-38870-ext-slice

Conversation

@isidentical

@isidenticalisidentical commented Jan 7, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal
pablogsal reviewed Jan 7, 2020
View reviewed changes
Comment threadLib/ast.py Outdated
pablogsal
pablogsal reviewed Jan 7, 2020
View reviewed changes
Comment threadLib/ast.py Outdated
Comment threadLib/ast.py Outdated
Comment threadLib/ast.py Outdated
@isidentical

isidentical commented Jan 7, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks for the suggestions @pablogsal!

pablogsal
pablogsal reviewed Jan 7, 2020
View reviewed changes
Comment threadLib/ast.py Outdated
@pablogsal

pablogsal commented Jan 7, 2020•
edited
Loading

Copy link
Copy Markdown
Member

The build is failing because you have trailing whitespace (you can run make patchcheck to make the fixes).

@isidentical

isidentical commented Mar 8, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Already fixed on the master with GH-18824

@isidentical

isidentical commented Mar 8, 2020

Copy link
Copy Markdown
MemberAuthor

Actually we can still apply this simplification

@isidenticalisidentical reopened this Mar 8, 2020
gvanrossum
gvanrossum approved these changes Mar 9, 2020
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good.

@gvanrossumgvanrossum mentioned this pull request Mar 9, 2020
Merged
pablogsal
pablogsal reviewed Mar 9, 2020
View reviewed changes
Comment threadLib/ast.py Outdated
@pablogsal
pablogsal merged commit e7cab7f into python:masterMar 9, 2020
colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
@isidentical@colesbury
bpo-38870: Simplify sequence interleaves in ast.unparse (GH-17892)
8bf4e55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes
@pablogsalpablogsalpablogsal approved these changes
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@isidentical@pablogsal@gvanrossum@the-knights-who-say-ni@bedevere-bot