Uh oh!
There was an error while loading. Please reload this page.
gh-75008: guess lineterminator in csv.Sniffer - #18336
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rruuaanng
left a comment
There was a problem hiding this comment.
Maybe csv.py should be sent to another reviewer for review.
This PR is stale because it has been open for 30 days with no activity. |
serhiy-storchaka
commented
Jul 21, 2026
Thank you for the patch, and sorry that it was left without attention for so long. The sniffer was rewritten on the main branch (gh-83273) and this patch no longer applies. It should be easier now: the sample is split into lines keeping their line breaks, so detection can count |
serhiy-storchaka
commented
Aug 1, 2026
#155061 implements this on the new engine. The only detail not covered above: the terminator is chosen by a majority vote among the line endings, with a tie broken in the order Closing as superseded. Thank you again for the patch. |
https://bugs.python.org/issue30825