bpo-39573: Add Py_IS_TYPE macro by corona10 · Pull Request #18488 · python/cpython

corona10 · 2020-02-12T16:54:07Z

https://bugs.python.org/issue39573

vstinner

I suggest to modify Argument Clinic in a separated PR, but use this PR to update PyXXX_CheckExact() macros. See: nascheme@c156300

You should credit Neil if you reuse his commit: add Author: Neil Schemenauer <nas-github@arctrix.com> at the end of your commit message.

codecov · 2020-02-12T17:38:49Z

Codecov Report

Merging #18488 into master will increase coverage by 1.08%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #18488 +/- ##
===========================================
+ Coverage 82.11% 83.19% +1.08% 
===========================================
Files 1956 1571 -385 Lines 589145 414668 -174477 Branches 44447 44450 +3 ===========================================
- Hits 483801 345002 -138799 + Misses 95697 60016 -35681 - Partials 9647 9650 +3

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-7.15%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.77%)`	⬇️
Lib/test/test_asyncio/test_base_events.py	`91.84% <0.00%> (-3.30%)`	⬇️
... and 439 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fac7ed...e49cc89. Read the comment docs.

Co-Author: Neil Schemenauer <nas-github@arctrix.com>

corona10

@vstinner I've updated the PR :)

corona10 · 2020-02-13T01:33:29Z

@vstinner Updated! Thanks for the review

vstinner · 2020-02-13T08:27:19Z

+ Equivalent to: Py_TYPE(o) == type.
+
+ .. versionadded:: 3.9
+


Ooops, I noticed a typo in one of my previous commit. Would you mind to take this PR as an opportunity to fix it?
https://docs.python.org/dev/c-api/structures.html#c.Py_SET_SIZE
"Set the object o size of size." => "Set ... to size."

Wait, @brandtbucher wrote PR #18496. I will ask him to fix the typo there. You can ignore this special request ;-)

Current
Suggestion
Looks like not work as we want ;)

corona10 · 2020-02-13T14:32:18Z

@vstinner Updated :)

vstinner · 2020-02-13T17:37:34Z

Thanks, merged. You can now redo your Argument Clinic change on top of it.

the-knights-who-say-ni added the CLA signed label Feb 12, 2020

bedevere-bot added the awaiting review label Feb 12, 2020

corona10 force-pushed the bpo-39573 branch from dd3c0d4 to 2457803Compare February 12, 2020 17:05

vstinner reviewed Feb 12, 2020
View reviewed changes

Comment threadInclude/object.h Outdated
Comment threadDoc/c-api/structures.rst Outdated

corona10 force-pushed the bpo-39573 branch from 2457803 to 1b156b0Compare February 12, 2020 17:35

bpo-39573: Add Py_IS_TYPE macro
42f1b0e

corona10 force-pushed the bpo-39573 branch from 1b156b0 to 42f1b0eCompare February 12, 2020 17:36

corona10 changed the title ~~bpo-39573: Add Py_IS_TYPE macro~~[WIP] bpo-39573: Add Py_IS_TYPE macroFeb 12, 2020

corona10 requested review from 1st1, abalkin and pganssle as code owners February 12, 2020 18:09

bpo-39573: Update PyXXX_CheckExact() APIs
b31905e
Co-Author: Neil Schemenauer <nas-github@arctrix.com>

corona10 force-pushed the bpo-39573 branch from bda8c2e to b31905eCompare February 12, 2020 18:14

corona10 changed the title ~~[WIP] bpo-39573: Add Py_IS_TYPE macro~~bpo-39573: Add Py_IS_TYPE macroFeb 12, 2020

corona10 requested a review from vstinner February 12, 2020 18:33

corona10 commented Feb 12, 2020
View reviewed changes

vstinner reviewed Feb 12, 2020
View reviewed changes

Comment threadDoc/c-api/structures.rst Outdated
Comment threadDoc/c-api/structures.rst Outdated
Comment threadMisc/NEWS.d/next/Core and Builtins/2020-02-13-01-30-22.bpo-39573.uTFj1m.rst Outdated

bpo-39573: Apply code review
6008716

corona10 force-pushed the bpo-39573 branch from 574e60c to 6008716Compare February 13, 2020 00:46

corona10 requested a review from vstinner February 13, 2020 01:33

vstinner reviewed Feb 13, 2020
View reviewed changes

bpo-39573: Apply code review
e49cc89

corona10 requested a review from vstinner February 13, 2020 14:32

vstinner merged commit d905df7 into python:masterFeb 13, 2020

bedevere-bot removed the awaiting review label Feb 13, 2020

vstinner mentioned this pull request Mar 12, 2024
[C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754
Closed

Uh oh!

Uh oh!

Conversation

corona10 commented Feb 12, 2020• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Feb 12, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

corona10 commented Feb 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinnerFeb 13, 2020

Choose a reason for hiding this comment

Uh oh!

corona10Feb 13, 2020

Choose a reason for hiding this comment

Uh oh!

vstinnerFeb 13, 2020

Choose a reason for hiding this comment

Uh oh!

corona10Feb 13, 2020

Choose a reason for hiding this comment

Uh oh!

corona10Feb 13, 2020

Choose a reason for hiding this comment

Current

Suggestion

Uh oh!

corona10 commented Feb 13, 2020

Uh oh!

vstinner commented Feb 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

corona10 commented Feb 12, 2020•
edited by bedevere-bot
Loading

codecovBot commented Feb 12, 2020•
edited
Loading