Skip to content

bpo-32892: Update the documentation for handling constants in AST. - #18514

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:ast-constant-docs
Feb 17, 2020
Merged

bpo-32892: Update the documentation for handling constants in AST.#18514
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:ast-constant-docs

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Feb 15, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

I included these changes in the PR for other AST changes #9605, but it was not merged in 3.8.

https://bugs.python.org/issue32892

isidentical
isidentical reviewed Feb 15, 2020
View reviewed changes

@isidenticalisidentical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These might clarify the doc a bit

Comment threadDoc/library/ast.rst Outdated
Comment threadDoc/library/ast.rst Outdated
@serhiy-storchaka@isidentical
Apply suggestions from code review
c01e0d3
Co-Authored-By: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
@serhiy-storchaka

serhiy-storchaka commented Feb 16, 2020

Copy link
Copy Markdown
MemberAuthor

Thank you for your corrections @isidentical! I always had problems with articles which are absent in my native language.

@serhiy-storchaka
serhiy-storchaka merged commit 85a2eef into python:masterFeb 17, 2020
@miss-islington

miss-islington commented Feb 17, 2020

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the ast-constant-docs branch February 17, 2020 09:03
@bedevere-bot

bedevere-bot commented Feb 17, 2020

Copy link
Copy Markdown

GH-18534 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Feb 17, 2020
@miss-islington@serhiy-storchaka
bpo-32892: Update the documentation for handling constants in AST. (G…
988aeba
…H-18514)
(cherry picked from commit 85a2eef)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidenticalisidenticalisidentical approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka@miss-islington@bedevere-bot@isidentical@the-knights-who-say-ni