bpo-10572: Move test sub-packages to Lib/test by idomic · Pull Request #18524 · python/cpython

idomic · 2020-02-16T18:07:16Z

https://bugs.python.org/issue10572

Co-Authored-By: Victor Stinner <vstinner@python.org>

…test: tkinter/test distutils/tests ctypes/tests lib2to3/tests sqlite3/test unittest/test

ned-deily

Please make sure that tests still run correctly when running from an installed instance of Python, not just from a development build directory. The various test directories are installed in the main Makefile (Makefile.pre.in) libinstall rule. I think you'll find that many tests are now broken. See the LIBSUBDIRS variable in the Makefile. (I see that the dev guide does not refer to this topic so I've opened a devguide issue about it: python/devguide#573)

bedevere-bot · 2020-02-16T20:46:30Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

idomic · 2020-02-16T21:48:22Z

Thanks @ned-deily , I've updated the makefile and adding a News file.
I have made the requested changes; please review again

bedevere-bot · 2020-02-16T21:48:25Z

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

… into bpo-10572-reArranging_Lib_tests

idomic · 2020-02-17T03:10:34Z

Ok I fixed all of the tests expect 1 in lib2to3 in which I'm not really sure what's going on.

idomic · 2020-02-23T01:11:11Z

When looking on the test that's failing:

test_write_filtered_python_package (test.test_zipfile.PyZipFileTests) ... File "/Users/runner/runners/2.164.0/work/cpython/cpython/Lib/test/lib2to3_tests/data/bom.py", line 2
print "BOM BOOM!"

It looks like it uses print syntax of python 2.7 which is not relevant anymore, any idea why is it there? I suspect in the master it was just not running and because now it's in the tests folder it's running by default.

I have made the requested changes; please review again

bedevere-bot · 2020-02-23T01:11:13Z

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

brettcannon · 2020-03-05T18:55:18Z

@idomic it looks like it's a test file for the lib2to3 test to use. There's probably a test that reads that file, runs lib2to3 on it, and checks the results. So that file is very likely there on purpose and meant to be Python 2 syntax.

brettcannon · 2020-03-05T18:56:02Z

@idomic you also have conflicts. It might be easier to do one PR per package so lessen the chances of merge conflicts occurring.

brettcannon

The merge conflicts need to be fixed, and I would strongly suggest breaking this PR up into single PRs per package.

bedevere-bot · 2020-03-13T20:41:34Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

idomic · 2020-03-15T13:46:58Z

The merge conflicts need to be fixed, and I would strongly suggest breaking this PR up into single PRs per package.

I'll submit a new PR with 1 package and will tag you and Ned

idomicand others added 5 commits February 13, 2020 17:56

Hard reset + cherry piciking the changes.
13c5b05

📜🤖 Added by blurb_it.
fdecdf0

Added@vstinnerNews
29d13c9

Update Misc/NEWS.d/next/Library/2020-02-11-13-01-38.bpo-38691.oND8Sk.rst
135259f
Co-Authored-By: Victor Stinner <vstinner@python.org>

Merge branch 'master' ofhttps://github.com/python/cpython
794b948

idomic requested review from berkerpeksag and rhettinger as code owners February 16, 2020 18:07

the-knights-who-say-ni added the CLA signed label Feb 16, 2020

bedevere-bot added the awaiting review label Feb 16, 2020

idomic added 2 commits February 16, 2020 13:13

Merge branch 'master' ofhttps://github.com/python/cpython
bfa3cd1

[bpo-10572] Moved tests of these modules under Lib/tests/MODULE_NAME_…
36b41eb
…test: tkinter/test distutils/tests ctypes/tests lib2to3/tests sqlite3/test unittest/test

idomic force-pushed the bpo-10572-reArranging_Lib_tests branch from 746c83b to 36b41ebCompare February 16, 2020 18:20

[bpo-10572] Changing test references for CI
69ad225

ned-deily requested changes Feb 16, 2020
View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Feb 16, 2020

idomic added 5 commits February 16, 2020 15:52

[bpo-10572] Adapting tests imports
8e7db7a

Merge branch 'master' ofhttps://github.com/python/cpython
71b4de5

Removed residues
4be42f0

Merge branch 'master' into bpo-10572-reArranging_Lib_tests
4a3cf9f

[bpo-10572] Changed Makefile.pre.in to contain the correct tests path
18c5f36

bedevere-bot added awaiting change review and removed awaiting changes labels Feb 16, 2020

bedevere-bot requested a review from ned-deily February 16, 2020 21:48

blurb-itBotand others added 3 commits February 16, 2020 21:51

📜🤖 Added by blurb_it.
60a14df

[bpo-10572] Changed Makefile.pre.in to contain the correct tests path
fbd63a8

Merge remote-tracking branch 'origin/bpo-10572-reArranging_Lib_tests'…
e3ff1cd
… into bpo-10572-reArranging_Lib_tests

idomic added 2 commits February 16, 2020 17:48

[bpo-10572] Changed Makefile.pre.in to contain the correct tests path
bb4e8b8

[bpo-10572] Fixing distutils tests path
65db1d2

idomic requested a review from a team as a code owner February 16, 2020 23:10

idomic added 10 commits February 16, 2020 18:14

[bpo-10572] Fixing Lib.test.tkinter_test tests path
7cfa472

[bpo-10572] Fixing Lib.test.unittest_test + ctypes tests path
fd7ed2b

[bpo-10572] Fixing Lib.test.unittest_test + test_lib2to3 tests path
6b32dd1

[bpo-10572] Fixing Lib.test.unittest_test + test_lib2to3 tests path
1021fcf

[bpo-10572] Fixed hardcoded Lib.test.unittest_test and lib2to3 path
f5431d8

[bpo-10572] Fixed hardcoded Lib.test.unittest_test and lib2to3 path
d89915f

[bpo-10572] Fixed hardcoded Lib.test.unittest_test and lib2to3 path
a5e9500

[bpo-10572] Fixed hardcoded Lib.test.unittest_test and lib2to3 path
19ab4cd

[bpo-10572] Fixed hardcoded Lib.test.unittest_test and lib2to3 path
1010154

[bpo-10572] Fixed hardcoded Lib.test.unittest_test and lib2to3 path
e65b43c

idomic added 2 commits February 16, 2020 22:54

[bpo-10572] Fixed hardcoded Lib.test.unittest_test and lib2to3 path
4609963

[bpo-10572] Fixed hardcoded Lib.test.unittest_test and lib2to3 path
c552264

brettcannon self-requested a review February 27, 2020 23:08

brettcannon requested changes Mar 13, 2020
View reviewed changes

bedevere-bot removed the awaiting change review label Mar 13, 2020

bedevere-bot added the awaiting changes label Mar 13, 2020

idomic closed this Mar 22, 2020

voidspace mentioned this pull request Jun 20, 2022
Move test sub-packages to Lib/test #54781
Closed

Navigation Menu

Uh oh!

Uh oh!

bpo-10572: Move test sub-packages to Lib/test - #18524

bpo-10572: Move test sub-packages to Lib/test#18524
idomic wants to merge 30 commits into
python:masterfrom
idomic:bpo-10572-reArranging_Lib_tests

idomic commented Feb 16, 2020•
edited by bedevere-bot
Loading

Uh oh!

ned-deily left a comment •
edited
Loading

Uh oh!

bedevere-bot commented Feb 16, 2020

Uh oh!

idomic commented Feb 16, 2020

Uh oh!

bedevere-bot commented Feb 16, 2020

Uh oh!

idomic commented Feb 17, 2020

Uh oh!

idomic commented Feb 23, 2020

Uh oh!

bedevere-bot commented Feb 23, 2020

Uh oh!

brettcannon commented Mar 5, 2020

Uh oh!

brettcannon commented Mar 5, 2020

Uh oh!

brettcannon left a comment

Uh oh!

bedevere-bot commented Mar 13, 2020

Uh oh!

idomic commented Mar 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

idomic commented Feb 16, 2020• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ned-deily left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Feb 16, 2020

Uh oh!

idomic commented Feb 16, 2020

Uh oh!

bedevere-bot commented Feb 16, 2020

Uh oh!

idomic commented Feb 17, 2020

Uh oh!

idomic commented Feb 23, 2020

Uh oh!

bedevere-bot commented Feb 23, 2020

Uh oh!

brettcannon commented Mar 5, 2020

Uh oh!

brettcannon commented Mar 5, 2020

Uh oh!

brettcannon left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Mar 13, 2020

Uh oh!

idomic commented Mar 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

idomic commented Feb 16, 2020•
edited by bedevere-bot
Loading

ned-deily left a comment •
edited
Loading