Skip to content

bpo-39674: Revert "bpo-25988: Do not expose abstract collection classes in the collections module. (GH-10596)" - #18545

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:revert_collections_abc
Feb 18, 2020
Merged

bpo-39674: Revert "bpo-25988: Do not expose abstract collection classes in the collections module. (GH-10596)"#18545
vstinner merged 1 commit into
python:masterfrom
vstinner:revert_collections_abc

Conversation

@vstinner

@vstinnervstinner commented Feb 18, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This reverts commit ef092fe.

Update collections getattr() and documentation to defer aliases
removal to Python 3.10.

https://bugs.python.org/issue39674

@vstinner
bpo-39674: Revert "bpo-25988: Do not expose abstract collection class…
23383c6
…es in the collections module. (GH-10596)"
This reverts commit ef092fe.
Update collections __getattr__() and documentation to defer aliases
removal to Python 3.10.
@vstinner

vstinner commented Feb 18, 2020

Copy link
Copy Markdown
MemberAuthor

Since https://bugs.python.org/issue39674 is controversial, I would prefer to get at least one formal approval of this revert from core developers.

cc @brettcannon@warsaw@serhiy-storchaka@gvanrossum@zooba

serhiy-storchaka
serhiy-storchaka approved these changes Feb 18, 2020
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do not care about other removals, but this change looks affecting too much code.

@codecov

codecovBot commented Feb 18, 2020•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #18545 into master will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #18545 +/- ##
===========================================
- Coverage 83.25% 82.12% -1.14% 
===========================================
Files 1571 1955 +384 Lines 414749 584050 +169301 Branches 44456 44457 +1 ===========================================
+ Hits 345302 479622 +134320 - Misses 59795 94780 +34985 + Partials 9652 9648 -4
Impacted FilesCoverage Δ
Lib/distutils/tests/test_bdist_rpm.py30.00% <0.00%> (-65.00%)⬇️
Lib/distutils/command/bdist_rpm.py7.63% <0.00%> (-56.88%)⬇️
Lib/test/test_urllib2net.py76.92% <0.00%> (-13.85%)⬇️
Lib/test/test_smtpnet.py78.57% <0.00%> (-7.15%)⬇️
Lib/ftplib.py63.85% <0.00%> (-6.06%)⬇️
Lib/test/test_ftplib.py87.11% <0.00%> (-4.72%)⬇️
Tools/scripts/db2pickle.py17.82% <0.00%> (-3.97%)⬇️
Tools/scripts/pickle2db.py16.98% <0.00%> (-3.78%)⬇️
Lib/test/test_socket.py71.94% <0.00%> (-3.77%)⬇️
Lib/test/test_asyncio/test_base_events.py91.84% <0.00%> (-3.30%)⬇️
... and 436 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d38517...23383c6. Read the comment docs.

@vstinner

vstinner commented Feb 18, 2020

Copy link
Copy Markdown
MemberAuthor

Data point from Fedora packages: around 65 packages failed to build because of commit ef092fe which removed the collections aliases.

See Miro's email: https://mail.python.org/archives/list/python-dev@python.org/message/LGGI42UEQMJVNW2ZHEP473Z7ZQ5BDBPL/

This revert should fix most of these packages. "most" because we don't know if packages build will fail for another reasons (maybe another deprecated function removed from Python 3.9).

@vstinner

vstinner commented Feb 18, 2020

Copy link
Copy Markdown
MemberAuthor

Fedora packages reported failures to most packages upstream and for some of them, we even proposed fixes.

@vstinner

vstinner commented Feb 18, 2020

Copy link
Copy Markdown
MemberAuthor

The macOS failure is: https://bugs.python.org/issue38691

@vstinner
vstinner merged commit af5ee3f into python:masterFeb 18, 2020
@vstinner
vstinner deleted the revert_collections_abc branch February 18, 2020 15:28
@vstinner

vstinner commented Feb 18, 2020

Copy link
Copy Markdown
MemberAuthor

Merged, thanks for the approval @serhiy-storchaka and @gvanrossum.

@terryjreedy

terryjreedy commented Feb 18, 2020

Copy link
Copy Markdown
Member

Shouldn't '3.8' in
"For backwards compatibility, they continue to be visible in this module through Python 3.8."
be changed to '3.9'?

FWIW, I also think this 1 reversion was the best thing to do and perhaps had more support than revert nothing and revert multiple things.

@hugovkhugovk mentioned this pull request Mar 1, 2020
Closed
3 tasks
@vstinner

vstinner commented Mar 2, 2020

Copy link
Copy Markdown
MemberAuthor

Shouldn't '3.8' in "For backwards compatibility, they continue to be visible in this module through Python 3.8." be changed to '3.9'?

Right: I created #18747 to update the doc.

@hugovkhugovk mentioned this pull request Dec 13, 2020
Merged
Anthchirp added a commit to Anthchirp/cpython that referenced this pull request Apr 8, 2021
@Anthchirp
Fix collections ABC deprecation notice
e81f1c3
The deprecation originally slated for 3.9 was deferred to 3.10
(bpo-39674, pythonGH-18545) and the documentation on the 3.8 release was
updated accordingly (pythonGH-18748). However the deprecation notice in
the code was left as is, and still indicates deprecation with 3.9.
Anthchirp added a commit to Anthchirp/cpython that referenced this pull request Apr 8, 2021
@Anthchirp
Fix collections ABC deprecation notice
4cb7348
The deprecation originally slated for 3.9 was deferred to 3.10
(bpo-39674, pythonGH-18545). However the deprecation notice in the release
was left as is, and still indicates deprecation with 3.9.
Also add a missing space in the message.
This was referenced Apr 8, 2021
Closed
Merged
vstinner pushed a commit that referenced this pull request Apr 8, 2021
@Anthchirp
bpo-39674: Fix collections ABC deprecation notice (GH-25281)
20d56bd
The deprecation originally slated for 3.9 was deferred to 3.10
(bpo-39674, GH-18545) and the documentation on the 3.8 release was
updated accordingly (GH-18748). However the deprecation notice in
the code was left as is, and still indicates deprecation with 3.9.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vstinner@terryjreedy@gvanrossum@serhiy-storchaka@the-knights-who-say-ni@bedevere-bot