Skip to content

bpo-37319: Deprecated support of non-integer arguments in random.randrange(). - #19112

Merged
serhiy-storchaka merged 10 commits into
python:masterfrom
serhiy-storchaka:randrange-index
Jan 25, 2021
Merged

bpo-37319: Deprecated support of non-integer arguments in random.randrange().#19112
serhiy-storchaka merged 10 commits into
python:masterfrom
serhiy-storchaka:randrange-index

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Mar 22, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@rhettinger

rhettinger commented Mar 22, 2020

Copy link
Copy Markdown
Contributor

I don't think this should be done. It churns an API that has been stable for two decades. It doesn't solve a real problem. It may break working code. It makes the code look gross. It will complicate maintenance.

rhettinger
rhettinger reviewed Mar 22, 2020
View reviewed changes
Comment threadLib/random.py
@alimcmaster1

alimcmaster1 commented Apr 11, 2020

Copy link
Copy Markdown

Looks like this is good to close from the discussion on https://bugs.python.org/issue37319 ?

@serhiy-storchaka
serhiy-storchaka deleted the randrange-index branch April 11, 2020 08:01
@serhiy-storchaka
serhiy-storchaka restored the randrange-index branch October 31, 2020 19:33
@serhiy-storchaka

serhiy-storchaka commented Oct 31, 2020

Copy link
Copy Markdown
MemberAuthor

Reopened because @rhettinger just opened a duplicate issue.

According to the same microbenchmark as in #23064, this PR provides a 10% speed up:

$ ./python -m timeit -s 'from random import randrange' 'randrange(15)' # baseline
500000 loops, best of 5: 515 nsec per loop
$ ./python -m timeit -s 'from random import randrange' 'randrange(15)' # new version
500000 loops, best of 5: 467 nsec per loop

rhettinger
rhettinger reviewed Oct 31, 2020
View reviewed changes
Comment threadLib/random.py
except TypeError:
istep = int(step)
if istep != step:
raise ValueError("non-integer step for randrange()")

@rhettingerrhettingerOct 31, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, the exception type should be converted to TypeError.

@serhiy-storchakaserhiy-storchakaOct 31, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we raise it with custom message or reraise the exception raised by index()?

@serhiy-storchakaserhiy-storchaka mentioned this pull request Dec 24, 2020
Merged
@serhiy-storchaka

serhiy-storchaka commented Dec 24, 2020

Copy link
Copy Markdown
MemberAuthor

@rhettinger, what are your problems with this PR? I addressed your comments, and would appreciate any other suggestions.

@rhettinger

rhettinger commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

I merged in PR 23064. If you want to make further modifications or improvements that would be welcome.

@serhiy-storchaka

serhiy-storchaka commented Dec 29, 2020

Copy link
Copy Markdown
MemberAuthor

I merged with master. Please make review.

@serhiy-storchaka
serhiy-storchaka merged commit f066bd9 into python:masterJan 25, 2021
@serhiy-storchaka
serhiy-storchaka deleted the randrange-index branch January 25, 2021 21:02
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@serhiy-storchaka@adorilson
bpo-37319: Improve documentation, code and tests of randrange. (pytho…
042869c
…nGH-19112)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettingerrhettingerrhettinger left review comments
@mdickinsonmdickinsonAwaiting requested review from mdickinson

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka@rhettinger@alimcmaster1@nenell12211@the-knights-who-say-ni@bedevere-bot