Skip to content

bpo-40024: Update xxxxmodule to use PyModule_AddType. - #19119

Merged
vstinner merged 16 commits into
python:masterfrom
corona10:bpo-40024-part2
Mar 24, 2020
Merged

bpo-40024: Update xxxxmodule to use PyModule_AddType.#19119
vstinner merged 16 commits into
python:masterfrom
corona10:bpo-40024-part2

Conversation

@corona10

@corona10corona10 commented Mar 23, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10
corona10 requested a review from vstinnerMarch 23, 2020 17:03
pganssle
pganssle reviewed Mar 23, 2020
View reviewed changes
Comment threadModules/_datetimemodule.c Outdated
dimaqq
dimaqq reviewed Mar 24, 2020
View reviewed changes
Comment threadModules/_datetimemodule.c Outdated
@corona10corona10 changed the title bpo-40024: Update xxxxmodule to use PyModule_AddType.[WIP] bpo-40024: Update xxxxmodule to use PyModule_AddType.Mar 24, 2020
@corona10corona10 changed the title [WIP] bpo-40024: Update xxxxmodule to use PyModule_AddType.bpo-40024: Update xxxxmodule to use PyModule_AddType.Mar 24, 2020
@corona10
corona10 requested a review from pganssleMarch 24, 2020 03:56
@corona10

corona10 commented Mar 24, 2020

Copy link
Copy Markdown
MemberAuthor

@vstinner@pganssle Please take a look :)

vstinner
vstinner reviewed Mar 24, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weakref_exec() of Modules/_weakref.c would also benefit of PyModule_AddType().

Comment threadModules/_io/_iomodule.c Outdated
Comment threadModules/_asynciomodule.c Outdated
Comment threadModules/_cursesmodule.c Outdated
@corona10

corona10 commented Mar 24, 2020

Copy link
Copy Markdown
MemberAuthor

@vstinner Updated! Please take a look.

@corona10
corona10 requested a review from vstinnerMarch 24, 2020 18:43
@vstinnervstinner mentioned this pull request Mar 24, 2020
Closed
@corona10

corona10 commented Mar 24, 2020

Copy link
Copy Markdown
MemberAuthor

@vstinner Updated!

@vstinner
vstinner merged commit 37fcbb6 into python:masterMar 24, 2020
@vstinner

vstinner commented Mar 24, 2020

Copy link
Copy Markdown
Member

Thanks @corona10, I merged your PR.

@corona10
corona10 deleted the bpo-40024-part2 branch March 28, 2020 15:50
@aerosaeros mentioned this pull request Apr 1, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st11st1Awaiting requested review from 1st1
@abalkinabalkinAwaiting requested review from abalkin
@asvetlovasvetlovAwaiting requested review from asvetlov
@rhettingerrhettingerAwaiting requested review from rhettinger
@tirantiranAwaiting requested review from tiran
@pgansslepganssleAwaiting requested review from pganssle
@vstinnervstinnerAwaiting requested review from vstinner
1 more reviewer
@dimaqqdimaqqdimaqq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@corona10@vstinner@dimaqq@pganssle@the-knights-who-say-ni@bedevere-bot