Skip to content

bpo-1635741: Port resource extension module to multiphase initialization(PEP 489) - #19252

Merged
vstinner merged 8 commits into
python:masterfrom
shihai1991:bpo_1635741_resource
Apr 2, 2020
Merged

bpo-1635741: Port resource extension module to multiphase initialization(PEP 489)#19252
vstinner merged 8 commits into
python:masterfrom
shihai1991:bpo_1635741_resource

Conversation

@shihai1991

@shihai1991shihai1991 commented Mar 31, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Comment threadModules/resource.c Outdated
corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Comment threadMisc/NEWS.d/next/Core and Builtins/2020-04-01-00-08-18.bpo-1635741.bhGWam.rst Outdated
corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Comment threadModules/resource.c Outdated
@corona10

corona10 commented Mar 31, 2020

Copy link
Copy Markdown
Member

@shihai1991 Thanks for the contribution :) I left some comments for you

corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Comment threadModules/resource.c Outdated
Comment threadModules/resource.c Outdated
corona10
corona10 approved these changes Apr 1, 2020
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10
corona10 requested a review from vstinnerApril 1, 2020 02:05
vstinner
vstinner requested changes Apr 1, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion to multiphase init is correct, but I would like to take the opportunity of this refactoring to fix error handling.

Comment threadModules/resource.c Outdated
Comment threadModules/resource.c
Comment threadModules/resource.c Outdated
@bedevere-bot

bedevere-bot commented Apr 1, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner

vstinner commented Apr 1, 2020

Copy link
Copy Markdown
Member

The macOS job failed because of https://bugs.python.org/issue40144

vstinner
vstinner reviewed Apr 1, 2020
View reviewed changes
Comment threadModules/resource.c Outdated
Comment threadModules/resource.c Outdated
@vstinner

vstinner commented Apr 2, 2020

Copy link
Copy Markdown
Member

The macOS job failed, see: https://bugs.python.org/issue40144

vstinner
vstinner reviewed Apr 2, 2020
View reviewed changes
Comment threadModules/resource.c Outdated
Comment threadModules/resource.c
Comment threadModules/resource.c Outdated
vstinner
vstinner approved these changes Apr 2, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix coding style issues.

Comment threadModules/resource.c Outdated
Comment threadModules/resource.c Outdated
Comment threadModules/resource.c Outdated
@vstinner

vstinner commented Apr 2, 2020

Copy link
Copy Markdown
Member

macOS is back to green, great ;-)

@vstinner
vstinner merged commit 45f7008 into python:masterApr 2, 2020
@vstinner

vstinner commented Apr 2, 2020

Copy link
Copy Markdown
Member

Thanks. I completed the commit message to mention refleak fixes.

@shihai1991

shihai1991 commented Apr 2, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks. I completed the commit message to mention refleak fixes.

Got it, thanks.

@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@corona10corona10corona10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shihai1991@corona10@bedevere-bot@vstinner@the-knights-who-say-ni