Uh oh!
There was an error while loading. Please reload this page.
bpo-40077: Remove redundant cast in _json extension module - #19438
Merged
Conversation
shihai1991
commented
Apr 8, 2020
MemberAuthor
@corona10 Hi, Dong-hee Na, congratulations! this cast is redundant, right? |
corona10
approved these changes
Apr 9, 2020
corona10
left a comment
Member
There was a problem hiding this comment.
Thanks for catching this :)
Since PyScannerType and PyEncoderType is PyObject*.
Casting is unnecessary things.
lgtm!
corona10
commented
Apr 9, 2020
Member
cc @vstinner |
shihai1991
commented
Apr 9, 2020
MemberAuthor
Thanks, MAYBE you can try use your merge right in this PR ;) |
vstinner
approved these changes
Apr 9, 2020
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. Usually, we don't accept coding style only changes. But I think that it's ok to make an exception here.
vstinner
commented
Apr 9, 2020
Member
@corona10: Congrats for your first merge ;-) |
corona10
commented
Apr 9, 2020
Member
@vstinner Thank you, it is the singularity of life |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40077