Skip to content

bpo-23082: Better error message for PurePath.relative_to() from pathlib - #19611

Merged
zooba merged 3 commits into
python:masterfrom
rotuna:issue-23803
May 25, 2020
Merged

bpo-23082: Better error message for PurePath.relative_to() from pathlib#19611
zooba merged 3 commits into
python:masterfrom
rotuna:issue-23803

Conversation

@rotuna

@rotunarotuna commented Apr 19, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Changed the error message to be more informative and updated the docs accordingly.

https://bugs.python.org/issue23082

Sadhana SrinivasanSadhana Srinivasan
Better error for PurePath.relative_to() from pathlib
b979a2f
Changed the error message to be more informative and updated the docs accordingly.
@the-knights-who-say-ni

the-knights-who-say-ni commented Apr 19, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rotuna

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@rotuna

rotuna commented Apr 22, 2020

Copy link
Copy Markdown
ContributorAuthor

@zooba Could you please review this PR?

@csabella
csabella requested a review from pitrouApril 23, 2020 12:04
zooba
zooba reviewed Apr 28, 2020
View reviewed changes
Comment threadLib/pathlib.py
@zooba

zooba commented Apr 28, 2020

Copy link
Copy Markdown
Member

Sorry for the delay - I had it flagged to follow-up, but life.

Pinging me on GitHub doesn't work either, btw (too many notifications; too hard to filter them). If you need my attention, please post on the bug.

@idomic

idomic commented May 24, 2020

Copy link
Copy Markdown
Contributor

The PR looks good pinging on the bug's page

@zooba
zooba merged commit 4483253 into python:masterMay 25, 2020
@miss-islington

miss-islington commented May 25, 2020

Copy link
Copy Markdown
Contributor

Thanks @rotuna for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2020
@rotuna@miss-islington
bpo-23082: Better error message for PurePath.relative_to() from pathl…
0149274
…ib (pythonGH-19611)
Co-authored-by: Sadhana Srinivasan <rotuna@Sadhanas-MBP.fritz.box>
(cherry picked from commit 4483253)
Co-authored-by: Rotuna <sadhanasrinivasan@protonmail.com>
@bedevere-bot

bedevere-bot commented May 25, 2020

Copy link
Copy Markdown

GH-20395 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request May 25, 2020
@miss-islington@rotuna
bpo-23082: Better error message for PurePath.relative_to() from pathl…
318a18e
…ib (GH-19611)
Co-authored-by: Sadhana Srinivasan <rotuna@Sadhanas-MBP.fritz.box>
(cherry picked from commit 4483253)
Co-authored-by: Rotuna <sadhanasrinivasan@protonmail.com>
domragusa added a commit to domragusa/cpython that referenced this pull request May 28, 2020
@domragusa
resolve conflicts withpythonGH-19611
6d721a0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zoobazoobazooba left review comments
@pitroupitrouAwaiting requested review from pitrou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rotuna@the-knights-who-say-ni@zooba@idomic@miss-islington@bedevere-bot