gh-74033: Fix bug when Path takes and ignores **kwargs by uriyyo · Pull Request #19632 · python/cpython

uriyyo · 2020-04-21T09:51:39Z

Fix a bug where Path takes and ignores **kwargs by adding to PurePath class __init__ method which can take only positional arguments.

Issue: Path takes and ignores **kwargs #74033

Automerge-Triggered-By: GH:brettcannon

remilapeyre

Thanks for writing the fix for this issue Yurii!

Co-Authored-By: Rémi Lapeyre <remi.lapeyre@henki.fr>

remilapeyre

Thanks!

remilapeyre

Hi @uriyyo, as I indicated on bpo, PurePath suffers from a similar issue, it and its subclasses cannot accept **kwargs.

Could you make the same changes to PurePath so the behaviour is the same for the whole module?

uriyyo · 2020-05-21T12:00:04Z

Hi @remilapeyre
Sure, I will update this PR.

uriyyo · 2020-05-21T14:58:16Z

Hi @remilapeyre
I update PR, can you review it?

remilapeyre

Thanks @uriyyo, I just tested your changes and it looks good to me 👍

I just proposed two small things

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>

uriyyo · 2020-05-22T06:58:44Z

@remilapeyre I agree with your suggestions, thanks.

netlify · 2022-12-06T22:44:46Z

✅ Deploy Preview for python-cpython-preview canceled.

Name	Link
🔨 Latest commit	`8ef2e9e`
🔍 Latest deploy log	https://app.netlify.com/sites/python-cpython-preview/deploys/638fc5db834885000837776c

brettcannon

Since "explicit is better than implicit", I think we want pathlib.Path to raise an error with keyword arguments instead of letting PurePath silently accept keyword arguments.

bedevere-bot · 2022-12-16T22:06:32Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Brett Cannon <brett@python.org>

uriyyo · 2022-12-17T08:48:36Z

I have made the requested changes; please review again

bedevere-bot · 2022-12-17T08:48:40Z

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

brettcannon

Unfortunately we need to ask that this raises a warning for at least 2 releases.

bedevere-bot · 2022-12-23T22:43:53Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

uriyyo · 2022-12-24T08:53:06Z

I have made the requested changes; please review again.

bedevere-bot · 2022-12-24T08:53:10Z

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

miss-islington · 2023-01-14T00:05:43Z

Status check is done, and it's a success ✅.

brettcannon · 2023-01-14T00:37:21Z

Thanks for the PR and the patience!

bpo-29847: Fix bug when Path takes and ignores **kwargs
4228d60

the-knights-who-say-ni added the CLA signed label Apr 21, 2020

bedevere-bot added the awaiting review label Apr 21, 2020

remilapeyre reviewed Apr 21, 2020
View reviewed changes

Comment threadLib/test/test_pathlib.py Outdated
Comment threadMisc/NEWS.d/next/Library/2020-04-18-17-45-03.bpo-29847.Uxtbq0.rst Outdated

uriyyoand others added 2 commits April 21, 2020 13:20

Update Misc/NEWS.d/next/Library/2020-04-18-17-45-03.bpo-29847.Uxtbq0.rst
72ffd24
Co-Authored-By: Rémi Lapeyre <remi.lapeyre@henki.fr>

Move tests from PathTest to _BasePathTest class
fc740ec

remilapeyre approved these changes Apr 21, 2020
View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Apr 21, 2020

remilapeyre suggested changes May 21, 2020
View reviewed changes

Fix bug when PurePath takes and ignores **kwargs
7dab30d

remilapeyre approved these changes May 21, 2020
View reviewed changes

Comment threadLib/test/test_pathlib.py Outdated
Comment threadMisc/NEWS.d/next/Library/2020-04-18-17-45-03.bpo-29847.Uxtbq0.rst Outdated

uriyyoand others added 2 commits May 22, 2020 09:56

Update Lib/test/test_pathlib.py
53c4b58
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>

Update Misc/NEWS.d/next/Library/2020-04-18-17-45-03.bpo-29847.Uxtbq0.rst
7bbc2a3
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>

uriyyo changed the title ~~bpo-29847: Fix bug when Path takes and ignores **kwargs~~bpo-29847: Fix bug when PurePath takes and ignores **kwargsMay 22, 2020

uriyyo changed the title ~~bpo-29847: Fix bug when PurePath takes and ignores **kwargs~~bpo-29847: Fix bug when Path takes and ignores **kwargsMay 22, 2020

ezio-melotti removed the CLA signed label Jul 13, 2022

JelleZijlstra mentioned this pull request Oct 10, 2022
Path takes and ignores **kwargs #74033
Closed

Merge branch 'main' into fix-issue-29847
8ef2e9e

iritkatriel requested a review from brettcannon as a code owner December 6, 2022 22:44

brettcannon changed the title ~~bpo-29847: Fix bug when Path takes and ignores **kwargs~~gh-74033: Fix bug when Path takes and ignores **kwargsDec 16, 2022

brettcannon requested changes Dec 16, 2022
View reviewed changes

Comment threadMisc/NEWS.d/next/Library/2020-04-18-17-45-03.bpo-29847.Uxtbq0.rst Outdated
Comment threadLib/pathlib.py Outdated
Comment threadLib/test/test_pathlib.py Outdated

bedevere-bot removed the awaiting core review label Dec 16, 2022

bedevere-bot added the awaiting changes label Dec 16, 2022

Update Misc/NEWS.d/next/Library/2020-04-18-17-45-03.bpo-29847.Uxtbq0.rst
3311d75
Co-authored-by: Brett Cannon <brett@python.org>

Remove kwargs from pathlib.Path; Remove redundant subclass test
f021d2b

bedevere-bot added awaiting change review and removed awaiting changes labels Dec 17, 2022

bedevere-bot requested a review from brettcannon December 17, 2022 08:48

brettcannon requested changes Dec 23, 2022
View reviewed changes

Comment threadLib/pathlib.py Outdated

bedevere-bot removed the awaiting change review label Dec 23, 2022

bedevere-bot added the awaiting changes label Dec 23, 2022

Add deprecation warning when calling Path with **kwargs
6fa22de

bedevere-bot added awaiting change review and removed awaiting changes labels Dec 24, 2022

bedevere-bot requested a review from brettcannon December 24, 2022 08:53

hauntsaninja added the topic-pathlib label Jan 7, 2023

brettcannon approved these changes Jan 13, 2023
View reviewed changes

Comment threadMisc/NEWS.d/next/Library/2020-04-18-17-45-03.bpo-29847.Uxtbq0.rst Outdated

bedevere-bot added awaiting merge and removed awaiting change review labels Jan 13, 2023

brettcannon requested a review from barneygale as a code owner January 13, 2023 23:40

brettcannon added 2 commits January 13, 2023 15:40

Update Misc/NEWS.d/next/Library/2020-04-18-17-45-03.bpo-29847.Uxtbq0.rst
c654dda

Merge branch 'main' into fix-issue-29847
71f662f

brettcannon added the 🤖 automerge label Jan 13, 2023

miss-islington merged commit 080cb27 into python:mainJan 14, 2023

bedevere-bot removed the awaiting merge label Jan 14, 2023

uriyyo deleted the fix-issue-29847 branch January 14, 2023 08:24

takluyver mentioned this pull request Sep 27, 2023
Remove destination data files if they exist. pypa/flit#658
Merged

Uh oh!

Uh oh!

Conversation

uriyyo commented Apr 21, 2020• edited by AlexWaygood Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

remilapeyre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

remilapeyre left a comment

Choose a reason for hiding this comment

Uh oh!

remilapeyre left a comment

Choose a reason for hiding this comment

Uh oh!

uriyyo commented May 21, 2020

Uh oh!

uriyyo commented May 21, 2020

Uh oh!

remilapeyre left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

uriyyo commented May 22, 2020

Uh oh!

netlifyBot commented Dec 6, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for python-cpython-preview canceled.

Uh oh!

brettcannon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Dec 16, 2022

Uh oh!

uriyyo commented Dec 17, 2022

Uh oh!

bedevere-bot commented Dec 17, 2022

Uh oh!

brettcannon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Dec 23, 2022

Uh oh!

uriyyo commented Dec 24, 2022

Uh oh!

bedevere-bot commented Dec 24, 2022

Uh oh!

Uh oh!

miss-islington commented Jan 14, 2023

Uh oh!

brettcannon commented Jan 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

uriyyo commented Apr 21, 2020•
edited by AlexWaygood
Loading

remilapeyre left a comment •
edited
Loading

netlifyBot commented Dec 6, 2022•
edited
Loading