Skip to content

bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it - #19648

Merged
zooba merged 1 commit into
python:masterfrom
hroncok:idle256ico
Oct 20, 2020
Merged

bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it#19648
zooba merged 1 commit into
python:masterfrom
hroncok:idle256ico

Conversation

@hroncok

@hroncokhroncok commented Apr 22, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@hroncokhroncok mentioned this pull request Apr 22, 2020
Merged
@terryjreedy

terryjreedy commented Apr 22, 2020

Copy link
Copy Markdown
Member

Thank you. I will take care of this when I can, and add the idlelib/NEWS.txt item.

@taleinat

taleinat commented Apr 25, 2020

Copy link
Copy Markdown
Contributor

Referring to @terryjreedy's request on the original PR GH-17473:

@taleinat Ned disposed of the .icns issue. Do you currently have a respository on Windows? If so, can you verify that IDLE runs with the current patch and new .ico file?

Tested now, works great on my Windows 10 machine.

@zooba
zooba merged commit faddc74 into python:masterOct 20, 2020
@hroncok
hroncok deleted the idle256ico branch October 20, 2020 12:25
@miss-islington

miss-islington commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

Thanks @hroncok for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

Thanks @hroncok for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Oct 20, 2020

Copy link
Copy Markdown

GH-22823 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2020
@hroncok@miss-islington
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (python…
d9e6242
…GH-19648)
(cherry picked from commit faddc74)
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2020
@hroncok@miss-islington
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (python…
29c1edb
…GH-19648)
(cherry picked from commit faddc74)
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@bedevere-bot

bedevere-bot commented Oct 20, 2020

Copy link
Copy Markdown

GH-22824 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Oct 20, 2020
@miss-islington@hroncok
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648)
d84e411
(cherry picked from commit faddc74)
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
miss-islington added a commit that referenced this pull request Oct 21, 2020
@miss-islington@hroncok
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648)
871c6cc
(cherry picked from commit faddc74)
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@hroncok@adorilson
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (python…
6b4980f
…GH-19648)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedyterryjreedyAwaiting requested review from terryjreedy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hroncok@terryjreedy@taleinat@miss-islington@bedevere-bot@zooba@the-knights-who-say-ni