Skip to content

bpo-40334: Disallow invalid single statements in the new parser - #19774

Merged
pablogsal merged 5 commits into
python:masterfrom
lysnikolaou:invalid-single-statements
Apr 29, 2020
Merged

bpo-40334: Disallow invalid single statements in the new parser#19774
pablogsal merged 5 commits into
python:masterfrom
lysnikolaou:invalid-single-statements

Conversation

@lysnikolaou

@lysnikolaoulysnikolaou commented Apr 28, 2020

Copy link
Copy Markdown
Member

After parsing is done, a single statement has to be checked for
additional lines and a SyntaxError must be raised, in case there
are any.

Closeswe-like-parsers#99.

https://bugs.python.org/issue40334

After parsing is done, a single statement has to be checked for
additional lines and a `SyntaxError` must be raised, in case there
are any.
Closeswe-like-parsers#99.
@lysnikolaou
lysnikolaou marked this pull request as ready for review April 29, 2020 00:16
Comment threadParser/pegen/pegen.c
Comment threadParser/pegen/pegen.c Outdated
Comment threadParser/pegen/pegen.c Outdated
Comment threadParser/pegen/pegen.c Outdated
Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
Comment threadParser/pegen/pegen.c
@pablogsal

Copy link
Copy Markdown
Member

Nice work! One test less to go :)

@lysnikolaou

Copy link
Copy Markdown
MemberAuthor

One test less to go :)

Yup! We're slowly getting there!

@pablogsal
pablogsal merged commit 6d65087 into python:masterApr 29, 2020
@lysnikolaou
lysnikolaou deleted the invalid-single-statements branch April 29, 2020 07:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiline single statement is allowed

4 participants

@lysnikolaou@pablogsal@the-knights-who-say-ni@bedevere-bot