Uh oh!
There was an error while loading. Please reload this page.
Add missing sys import to socket_helper.py - #19791
Merged
Merged
Conversation
pablogsal
commented
Apr 29, 2020
MemberAuthor
There was a missing import that could cause: Traceback (mostrecentcalllast):
File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/test/support/socket_helper.py", line242, intransient_internetyieldFile"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/test/test_nntplib.py", line320, insetUpClasscls.server=cls.NNTP_CLASS(cls.NNTP_HOST,
File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/nntplib.py", line1043, in__init__super().__init__(host, port, user, password, readermode,
File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/nntplib.py", line1010, in__init__super().__init__(file, host, readermode, timeout)
File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/nntplib.py", line330, in__init__self.welcome=self._getresp()
File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/nntplib.py", line455, in_getrespraiseNNTPTemporaryError(resp)
nntplib.NNTPTemporaryError: 400Permissiondenied: ToomanyunknowncommandssenttotheserverTraceback (mostrecentcalllast):
File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/test/test_nntplib.py", line330, insetUpClassraiseunittest.SkipTest(f"{cls} got EOF error on connecting "File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/contextlib.py", line135, in__exit__self.gen.throw(type, value, traceback)
File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/test/support/socket_helper.py", line245, intransient_internetsys.stderr.write(denied.args[0] +"\n")
NameError: name'sys'isnotdefined |
pablogsal
commented
Apr 29, 2020
MemberAuthor
I am merging this as is causing a lot of buildbot failures and is a trivial fix. |
serhiy-storchaka
commented
Apr 30, 2020
Member
Thank you Pablo. |
vstinner
commented
Apr 30, 2020
Member
I ran pyflakes to check imports and created https://bugs.python.org/issue40443 as a follow-up :-) |
vstinner
commented
May 1, 2020
Member
Oh, it was worth it, I found another bug ;-) #19825 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.