Uh oh!
There was an error while loading. Please reload this page.
bpo-40334: Simplify type handling in the PEG c_generator - #19818
Merged
Conversation
lysnikolaou
approved these changes
Apr 30, 2020
lysnikolaou
left a comment
Member
There was a problem hiding this comment.
Truly great improvements, this and #19775.
gvanrossum
commented
Apr 30, 2020
Member
There's a conflict. Looks like you have to run |
pablogsal
commented
May 1, 2020
MemberAuthor
Thanks both for the review! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #19775. With this PR almost all the type-deducing code in
add_varcan be eliminated :)As a bonus, this PR eliminates some extra
void*in the generated code :)https://bugs.python.org/issue40334