Skip to content

bpo-39573: Use Py_IS_TYPE to check for types - #19882

Merged
corona10 merged 1 commit into
python:masterfrom
shihai1991:bpo_39573_Py_IS_TYPE
May 4, 2020
Merged

bpo-39573: Use Py_IS_TYPE to check for types#19882
corona10 merged 1 commit into
python:masterfrom
shihai1991:bpo_39573_Py_IS_TYPE

Conversation

@shihai1991

@shihai1991shihai1991 commented May 3, 2020

Copy link
Copy Markdown
Member

@shihai1991

Copy link
Copy Markdown
MemberAuthor

rough idea: Can we create a review robot to remind committer use the common macros or inline functions?

@corona10corona10 changed the title WIP: Use Py_IS_TYPE to check for typesbpo-39573: [WIP] Use Py_IS_TYPE to check for typesMay 3, 2020
@corona10

corona10 commented May 3, 2020

Copy link
Copy Markdown
Member

This PR can be part of bpo-39573 which actually introducing and applying Py_IS_TYPE for the first time.

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often do not accept the PR which can be just refactoring work with insignificant reason.
However, this PR is handling module what #18521 did not.
So I approve of this change as the exception.

But we need to hear @vstinner 's opinion :)

Thanks for the work

@shihai1991

Copy link
Copy Markdown
MemberAuthor

This PR can be part of bpo-39573 which actually introducing and applying Py_IS_TYPE for the first time.

yeap. You are the author ;)

@shihai1991shihai1991 changed the title bpo-39573: [WIP] Use Py_IS_TYPE to check for typesbpo-39573: Use Py_IS_TYPE to check for typesMay 3, 2020
@corona10

Copy link
Copy Markdown
Member

@shihai1991
But I approve the current change, so if the PR is updated for the more module.
Please request a review again.

@shihai1991

Copy link
Copy Markdown
MemberAuthor

@shihai1991
But I approve the current change, so if the PR is updated for the more module.
Please request a review again.

Thanks, I have checked all modules, there have no more should be ported.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991@corona10@the-knights-who-say-ni@bedevere-bot