Skip to content

bpo-1944: wrap functions with macro - #20011

Closed
furkanonder wants to merge 1 commit into
python:masterfrom
furkanonder:bpo-1944
Closed

bpo-1944: wrap functions with macro#20011
furkanonder wants to merge 1 commit into
python:masterfrom
furkanonder:bpo-1944

Conversation

@furkanonder

@furkanonderfurkanonder commented May 8, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

vstinner
vstinner requested changes May 10, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include/cpython/unicodeobject.h in only included if Py_LIMITED_API macro is not defined. This change looks useful, I don't understand its pupose.

Comment threadInclude/cpython/unicodeobject.h
@bedevere-bot

bedevere-bot commented May 10, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bedevere-appbedevere-appBot mentioned this pull request Dec 14, 2024
Closed
33 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@furkanonder@bedevere-bot@vstinner@the-knights-who-say-ni