Skip to content

bpo-40669: Use requirements.pip when installing PEG dependencies - #20194

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-40669
May 18, 2020
Merged

bpo-40669: Use requirements.pip when installing PEG dependencies#20194
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-40669

Conversation

@pablogsal

@pablogsalpablogsal commented May 18, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsalpablogsal mentioned this pull request May 18, 2020
Merged
@pablogsalpablogsal reopened this May 18, 2020
lysnikolaou
lysnikolaou approved these changes May 18, 2020
View reviewed changes

@lysnikolaoulysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want -U?

@pablogsal

pablogsal commented May 18, 2020

Copy link
Copy Markdown
MemberAuthor

Do we also want -U?

Given that this code won't trigger unless there is no venv I don't think it matters.

@lysnikolaou

lysnikolaou commented May 18, 2020

Copy link
Copy Markdown
Member

Do we also want -U?

Given that this code won't trigger unless there is no venv I don't think it matters.

Ok, go for it!

@pablogsal
pablogsal merged commit 3764069 into python:masterMay 18, 2020
@pablogsal
pablogsal deleted the bpo-40669 branch May 18, 2020 22:37
@miss-islington

miss-islington commented May 19, 2020

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2020
@pablogsal@miss-islington
bpo-40669: Use requirements.pip when installing PEG dependencies (pyt…
a08549c
…honGH-20194)
(cherry picked from commit 3764069)
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot

bedevere-bot commented May 19, 2020

Copy link
Copy Markdown

GH-20203 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request May 19, 2020
@miss-islington@pablogsal
bpo-40669: Use requirements.pip when installing PEG dependencies (GH-…
3d06282
…20194)
(cherry picked from commit 3764069)
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@pablogsal@arturoescaip
bpo-40669: Use requirements.pip when installing PEG dependencies (pyt…
aeab26a
…honGH-20194)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes
@lysnikolaoulysnikolaoulysnikolaou approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pablogsal@lysnikolaou@miss-islington@bedevere-bot@gvanrossum@ambv@the-knights-who-say-ni