Uh oh!
There was an error while loading. Please reload this page.
Fix code-block in zoneinfo - #20201
Conversation
Warning, treated as error:
/tmp/code/Doc/library/zoneinfo.rst:303:Error in "code-block" directive:
1 argument(s) required, 0 supplied.
.. code-block::
>>> a = ZoneInfo("Europe/Berlin")
>>> b = pickle.loads(europe_berlin_pkl)
>>> a is b
Trueasottile
commented
May 19, 2020
ambv
commented
May 19, 2020
Good catch, sorry for your trouble. Since the tag is already published, you'll have to cherrypick this for your build, is that okay? |
asottile
commented
May 19, 2020
yep! already applied it as a local patch which'll get removed for b1 🎉 |
pganssle
commented
May 19, 2020
Thanks for the PR! Does it not seem imprudent to enforce a more strict docs build on a redistribution than on upstream? Seems to me the feedback loop would be annoyingly long. Should we change our CI to catch these issues? |
miss-islington
commented
May 19, 2020
Thanks @asottile for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
```
Warning, treated as error:
/tmp/code/Doc/library/zoneinfo.rst:303:Error in "code-block" directive:
1 argument(s) required, 0 supplied.
.. code-block::
>>> a = ZoneInfo("Europe/Berlin")
>>> b = pickle.loads(europe_berlin_pkl)
>>> a is b
True
```
(cherry picked from commit 9095f76)
Co-authored-by: Anthony Sottile <asottile@umich.edu>bedevere-bot
commented
May 19, 2020
GH-20204 is a backport of this pull request to the 3.9 branch. |
ambv
commented
May 19, 2020
The full release docs build is rather longish because it builds letter and A4 PDFs too with TeX etc. etc. So we only do that for RCs and stable releases. Making a minimal HTML build every time seems like something we want to have. |
pganssle
commented
May 19, 2020
@ambv Ah, thanks. I was thinking this was a build with Thanks! |
```
Warning, treated as error:
/tmp/code/Doc/library/zoneinfo.rst:303:Error in "code-block" directive:
1 argument(s) required, 0 supplied.
.. code-block::
>>> a = ZoneInfo("Europe/Berlin")
>>> b = pickle.loads(europe_berlin_pkl)
>>> a is b
True
```
(cherry picked from commit 9095f76)
Co-authored-by: Anthony Sottile <asottile@umich.edu>```
Warning, treated as error:
/tmp/code/Doc/library/zoneinfo.rst:303:Error in "code-block" directive:
1 argument(s) required, 0 supplied.
.. code-block::
>>> a = ZoneInfo("Europe/Berlin")
>>> b = pickle.loads(europe_berlin_pkl)
>>> a is b
True
```
Automerge-Triggered-By: @pganssle