Skip to content

bpo-39573: Convert Py_TYPE() to a static inline function - #20290

Merged
corona10 merged 6 commits into
python:masterfrom
corona10:bpo-39573-py-type
May 25, 2020
Merged

bpo-39573: Convert Py_TYPE() to a static inline function#20290
corona10 merged 6 commits into
python:masterfrom
corona10:bpo-39573-py-type

Conversation

@corona10

@corona10corona10 commented May 21, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10
corona10 requested a review from vstinnerMay 21, 2020 15:59
vstinner
vstinner reviewed May 22, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I was waiting for Python 3.10 to do this change.

cc @nascheme

Comment threadDoc/c-api/structures.rst
@corona10

corona10 commented May 22, 2020

Copy link
Copy Markdown
MemberAuthor

@vstinner Updated!

@corona10
corona10 requested a review from vstinnerMay 22, 2020 15:06
vstinner
vstinner reviewed May 25, 2020
View reviewed changes
Comment threadDoc/whatsnew/3.10.rst
Comment threadDoc/whatsnew/3.10.rst Outdated
vstinner
vstinner reviewed May 25, 2020
View reviewed changes
Comment threadDoc/whatsnew/3.10.rst Outdated
Comment threadDoc/c-api/structures.rst Outdated
corona10and others added 2 commits May 26, 2020 01:11
@corona10@vstinner
Update Doc/whatsnew/3.10.rst
4306ac8
Co-authored-by: Victor Stinner <vstinner@python.org>
@corona10@vstinner
Update Doc/c-api/structures.rst
cd3c677
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner reviewed May 25, 2020
View reviewed changes
Comment threadInclude/object.h
vstinner
vstinner approved these changes May 25, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My comments about "const" can be addressed in a separated PR.

Comment threadDoc/c-api/structures.rst Outdated
@corona10
corona10 merged commit ad3252b into python:masterMay 25, 2020
@tacaswelltacaswell mentioned this pull request May 28, 2020
Merged
tacaswell added a commit to tacaswell/numpy that referenced this pull request May 29, 2020
@tacaswell
MNT: support python 3.10
405c6de
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function. This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.
In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function. This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
tacaswell added a commit to tacaswell/pycurl that referenced this pull request May 29, 2020
@tacaswell
MNT: support py310
a5312df
There was a change in the CPython c-api to change `Py_TYPE` from a
macro to an inline
function (python/cpython#20290). This
requires a change to using `Py_SET_TYPE` which was introduced on
py39a4.
@tacaswelltacaswell mentioned this pull request May 29, 2020
Closed
charris pushed a commit to charris/numpy that referenced this pull request May 29, 2020
@tacaswell@charris
MNT: support python 3.10
0e58c3c
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function. This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.
In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function. This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
@charrischarris mentioned this pull request May 29, 2020
Merged
@vstinnervstinner mentioned this pull request Jun 3, 2021
Merged
cielavenir pushed a commit to cielavenir/numpy that referenced this pull request Aug 9, 2023
@tacaswellTaiju Yamada
MNT: support python 3.10
86e96a0
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function. This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.
In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function. This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
cielavenir pushed a commit to cielavenir/numpy that referenced this pull request Aug 22, 2023
@tacaswellTaiju Yamada
MNT: support python 3.10
3a863bf
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function. This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.
In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function. This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
@vstinnervstinner mentioned this pull request Mar 12, 2024
Closed
cielavenir pushed a commit to cielavenir/numpy that referenced this pull request Nov 5, 2025
@tacaswellTaiju Yamada
MNT: support python 3.10
7ea5729
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function. This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.
In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function. This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@vstinner@the-knights-who-say-ni@bedevere-bot