Uh oh!
There was an error while loading. Please reload this page.
bpo-30064: Fix asyncio loop.sock_* race condition issue - #20369
Merged
Conversation
fantixforce-pushed
the
fix-issue-30064
branch
2 times, most recently
from
May 25, 2020 20:20
f65e373 to
a246122Compare1st1
reviewed
May 25, 2020
Uh oh!
There was an error while loading. Please reload this page.
1st1
reviewed
May 25, 2020
Uh oh!
There was an error while loading. Please reload this page.
1st1
approved these changes
May 26, 2020
1st1
commented
May 26, 2020
Member
@asvetlov Please take a look if you have a few minutes. |
miss-islington
commented
May 27, 2020
Contributor
1st1
commented
May 27, 2020
Member
Thanks, Fantix! |
bedevere-bot
commented
May 27, 2020
GH-20460 is a backport of this pull request to the 3.9 branch. |
miss-islington added a commit
that referenced
this pull request
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30064
This is reproducible by a
cancel()followed directly by a retry:This issue applies to all the
loop.sock_*methods. Without this PR, users could work it around by adding asleep(0):