Skip to content

bpo-40275: Fix a calling bug in threading_helper - #20479

Closed
shihai1991 wants to merge 1 commit into
python:masterfrom
shihai1991:bpo_40275_threading_helper_bugfix
Closed

bpo-40275: Fix a calling bug in threading_helper#20479
shihai1991 wants to merge 1 commit into
python:masterfrom
shihai1991:bpo_40275_threading_helper_bugfix

Conversation

@shihai1991

@shihai1991shihai1991 commented May 28, 2020

Copy link
Copy Markdown
Member

@shihai1991

Copy link
Copy Markdown
MemberAuthor

TODO: test tools should have unittest too.

@shihai1991

Copy link
Copy Markdown
MemberAuthor

@vstinner Hi, victor. Pls take a look if you have free time. Sorry, I introduced a potential bug in threading_helper :(

@vstinner

Copy link
Copy Markdown
Member

Oh right, there are a few more:

$ pyflakes Lib/test/support/threading_helper.py Lib/test/support/threading_helper.py:50:9 undefined name 'gc_collect'
Lib/test/support/threading_helper.py:101:13 undefined name 'gc_collect'
Lib/test/support/threading_helper.py:127:16 undefined name 'verbose'
Lib/test/support/threading_helper.py:136:23 local variable 'starttime' is assigned to but never used
Lib/test/support/threading_helper.py:144:20 undefined name 'verbose'
Lib/test/support/threading_helper.py:150:45 undefined name 'sys'

@vstinner

vstinner commented May 28, 2020

Copy link
Copy Markdown
Member

These bugs caused multiple buildbots failures: #20448 (comment)

I created PR #20488 to fix all pyflakes warning.

@vstinner

Copy link
Copy Markdown
Member

@vstinner Hi, victor. Pls take a look if you have free time. Sorry, I introduced a potential bug in threading_helper :(

That's ok. I didn't spot these issues neither, and test_support passed.

@vstinner

Copy link
Copy Markdown
Member

I merged my #20488 instead.

@shihai1991

Copy link
Copy Markdown
MemberAuthor

I merged my #20488 instead.

Got it, thanks.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991@vstinner@the-knights-who-say-ni@bedevere-bot