Skip to content

bpo-29602: fix signed zero handling in complex constructor - #205

Merged
mdickinson merged 1 commit into
python:3.5from
mdickinson:bpo-29549-backport-to-3.5
Feb 20, 2017
Merged

bpo-29602: fix signed zero handling in complex constructor#205
mdickinson merged 1 commit into
python:3.5from
mdickinson:bpo-29549-backport-to-3.5

Conversation

@mdickinson

Copy link
Copy Markdown
Member

Backport of #203 to branch for 3.5.

* Fix incorrect handling of signed zeros for complex-related classes.
* Add Misc/NEWS entry.
(cherry picked from commit 112ec38)
@mdickinsonmdickinson added type-bug An unexpected behavior, bug, or error cherry-pick for 3.5 labels Feb 20, 2017
@codecov

codecovBot commented Feb 20, 2017

Copy link
Copy Markdown

Codecov Report

Merging #205 into 3.5 will increase coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## 3.5 #205 +/- ##
==========================================
+ Coverage 82.41% 82.41% +<.01% 
==========================================
Files 1404 1404 Lines 341433 341454 +21 ==========================================
+ Hits 281390 281411 +21 
Misses 60043 60043
Impacted FilesCoverage Δ
Lib/test/test_complex.py98.41% <100%> (+0.06%)
Lib/test/test_select.py87.69% <ø> (-1.54%)
Lib/threading.py81.73% <ø> (-0.87%)
Lib/test/test_poll.py92.02% <ø> (-0.62%)
Lib/test/lock_tests.py86.17% <ø> (-0.59%)
Lib/test/test_thread.py66.32% <ø> (-0.52%)
Lib/nntplib.py81.21% <ø> (-0.36%)
Lib/test/test_buffer.py96.53% <ø> (-0.18%)
Lib/test/test_weakref.py96.58% <ø> (-0.16%)
Lib/pydoc.py62.05% <ø> (-0.07%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66fa9d4...ca7fcf4. Read the comment docs.

@mdickinson
mdickinson merged commit 0936a00 into python:3.5Feb 20, 2017
@mdickinson
mdickinson deleted the bpo-29549-backport-to-3.5 branch February 20, 2017 21:50
akruis added a commit to akruis/cpython that referenced this pull request Jan 13, 2019
The recent changes broke building with STACKLESS_OFF
(Usually $ make CFLAGS=-DSTACKLESS_OFF).
Now it works again.
jaraco pushed a commit that referenced this pull request Dec 2, 2022
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bugAn unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mdickinson@serhiy-storchaka@the-knights-who-say-ni