Skip to content

bpo-40937: Do not expose abstract collection classes in the collections module - #20774

Closed
remilapeyre wants to merge 4 commits into
python:masterfrom
remilapeyre:bpo-40937-collections
Closed

bpo-40937: Do not expose abstract collection classes in the collections module#20774
remilapeyre wants to merge 4 commits into
python:masterfrom
remilapeyre:bpo-40937-collections

Conversation

@remilapeyre

@remilapeyreremilapeyre commented Jun 10, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown

Original patch in ef092fe by Serhiy Storchaka

https://bugs.python.org/issue40937

@remilapeyreremilapeyre changed the title Do not expose abstract collection classes in the collections modulebpo-40937: Do not expose abstract collection classes in the collections moduleJun 10, 2020
@rhettinger

rhettinger commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

LGTM.

@rhettinger

rhettinger commented Jun 11, 2020

Copy link
Copy Markdown
Contributor

Have Serhiy take a look this. He's up to date on how long this has been deferred and where the essential downstream packages have been updated yet.

serhiy-storchaka
serhiy-storchaka requested changes Jun 13, 2020
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a What's New entry.

@bedevere-bot

bedevere-bot commented Jun 13, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre

remilapeyre commented Jun 15, 2020

Copy link
Copy Markdown
Author

Thanks, I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jun 15, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@tirkarthi

tirkarthi commented Jun 20, 2020

Copy link
Copy Markdown
Member

FWIW, I created 100 issues across 3500 top PyPI packages about this. There were also several reports from Fedora about this when they updated to Python 3.9. https://github.com/search?q=is%3Aissue+author%3Atirkarthi+archived%3Afalse+collections

@serhiy-storchaka

serhiy-storchaka commented Dec 29, 2020

Copy link
Copy Markdown
Member

See also #23754.

@rhettinger, merge please one of these PRs.

@serhiy-storchakaserhiy-storchaka mentioned this pull request Dec 29, 2020
Merged
@rhettinger

rhettinger commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

That isn't up to me. Try @pablogsal

@serhiy-storchakaserhiy-storchaka removed their assignment Jan 2, 2021
@hugovk

hugovk commented Jan 13, 2021

Copy link
Copy Markdown
Member

This removal has been merged via #23754.

Thanks for the PR!

@remilapeyreremilapeyremannequin mentioned this pull request Jun 25, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@remilapeyre@rhettinger@bedevere-bot@tirkarthi@serhiy-storchaka@hugovk@pablogsal@the-knights-who-say-ni