Skip to content

bpo-32604: Disable failing tests - #20777

Merged
nanjekyejoannah merged 1 commit into
python:masterfrom
nanjekyejoannah:fix_race
Jun 21, 2020
Merged

bpo-32604: Disable failing tests#20777
nanjekyejoannah merged 1 commit into
python:masterfrom
nanjekyejoannah:fix_race

Conversation

@nanjekyejoannah

@nanjekyejoannahnanjekyejoannah commented Jun 10, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

I decided to skip the tests in question until I get time to fix the races.

Requesting a second eye @pablogsal and @vstinner if this makes the bots green.

https://bugs.python.org/issue32604

@bedevere-botbedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jun 10, 2020
ericsnowcurrently
ericsnowcurrently approved these changes Jun 17, 2020
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll see if we can track down the problem by the end of the week and get those tests re-enabled.

@vstinner

vstinner commented Jun 17, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The PR title is very misleading: "bpo-32604: PEP 554 implementation: add interpreters module #20777".

@nanjekyejoannahnanjekyejoannah changed the title bpo-32604: PEP 554 implementation: add interpreters modulebpo-32604: Disable failing testsJun 17, 2020
@nanjekyejoannah
nanjekyejoannah merged commit 6f79838 into python:masterJun 21, 2020
@nanjekyejoannah

nanjekyejoannah commented Jun 22, 2020

Copy link
Copy Markdown
ContributorAuthor

Merging until we get a fix @ericsnowcurrently

fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@nanjekyejoannahnanjekyejoannah@fasihahmad
Skip tests to fix bot (pythonGH-20777)
69b3080
Co-authored-by: nanjekyejoannah <joannah.nanjekye@ibm.com>
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes
@vstinnervstinnerAwaiting requested review from vstinner
@pablogsalpablogsalAwaiting requested review from pablogsal

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nanjekyejoannah@vstinner@ericsnowcurrently@the-knights-who-say-ni@bedevere-bot