Skip to content

bpo-40959: Remove unused and unneeded declarations from sqlite3 headers - #20828

Merged
berkerpeksag merged 1 commit into
python:masterfrom
erlend-aasland:fix-issue-40959
Jan 6, 2021
Merged

bpo-40959: Remove unused and unneeded declarations from sqlite3 headers#20828
berkerpeksag merged 1 commit into
python:masterfrom
erlend-aasland:fix-issue-40959

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jun 12, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

I guess skipping NEWS is ok for this one.

https://bugs.python.org/issue40959

@erlend-aasland

erlend-aasland commented Jun 12, 2020

Copy link
Copy Markdown
ContributorAuthor

@berkerpeksag If you feel I'm flooding you with PR's/code reviewing, please let me know. Also, I might have missed a point or two in the devs guide, so if I'm proceeding with PR's/issues in a totally incorrect matter, feel free to point me in the right direction.

@erlend-aasland

erlend-aasland commented Oct 1, 2020

Copy link
Copy Markdown
ContributorAuthor

FYI, rebased onto master

@erlend-aasland

erlend-aasland commented Oct 17, 2020

Copy link
Copy Markdown
ContributorAuthor

@corona10 would you mind reviewing this? It's a straight-forward cleanup of the _sqlite3 header files:

  • remove function declarations for functions that are not used by other .c files
  • remove function declarations for functions that don't exist anymore

Diffstat:

 Modules/_sqlite/cache.h | 5 -----
Modules/_sqlite/connection.h | 7 -------
Modules/_sqlite/cursor.h | 10 ----------
Modules/_sqlite/prepare_protocol.h | 3 ---
Modules/_sqlite/statement.h | 1 -
5 files changed, 26 deletions(-)

berkerpeksag
berkerpeksag approved these changes Jan 6, 2021
View reviewed changes

@berkerpeksagberkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you please fix merge conflicts?

@erlend-aasland

erlend-aasland commented Jan 6, 2021

Copy link
Copy Markdown
ContributorAuthor

LGTM! Could you please fix merge conflicts?

Sure. 2 sec...

berkerpeksag
berkerpeksag approved these changes Jan 6, 2021
View reviewed changes

@berkerpeksagberkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berkerpeksag
berkerpeksag merged commit 203b249 into python:masterJan 6, 2021
@erlend-aaslanderlend-aasland mentioned this pull request Jan 6, 2021
Closed
@erlend-aaslanderlend-aasland mentioned this pull request Feb 19, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland@adorilson
bpo-40959: Remove unused declarations from sqlite3 headers (pythonGH-…
93b6d03
…20828)
@erlend-aasland
erlend-aasland deleted the fix-issue-40959 branch August 22, 2023 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksagberkerpeksagberkerpeksag approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@berkerpeksag@the-knights-who-say-ni@bedevere-bot