Uh oh!
There was an error while loading. Please reload this page.
bpo-1635741: Port _dbm module to multiphase initialization - #20848
Conversation
corona10
commented
Jun 13, 2020
@shihai1991 PTAL! |
I' ve checked the memory leak with these scripts and no leaks found deftest_dbm(self):
code=textwrap.dedent(r""" import glob import test.support dbm = test.support.import_module('_dbm') _fname = test.support.TESTFN def delete_files(): for f in glob.glob(_fname + "*"): test.support.unlink(f) f = dbm.open(_fname, 'n') f[b'g'] = b"indented" f.close() delete_files() """)
ret=test.support.run_in_subinterp(code)
self.assertEqual(ret, 0) |
Uh oh!
There was an error while loading. Please reload this page.
corona10
left a comment
There was a problem hiding this comment.
@shihai1991 Thanks shihai! I've updated it
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Jun 15, 2020
When you're done making the requested changes, leave the comment: |
corona10
left a comment
There was a problem hiding this comment.
I have made the requested changes; please review again
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
https://bugs.python.org/issue1635741