Skip to content

bpo-36346: Make unicodeobject.h C89 compatible - #20934

Merged
methane merged 1 commit into
python:masterfrom
methane:fix-buildbot
Jun 17, 2020
Merged

bpo-36346: Make unicodeobject.h C89 compatible#20934
methane merged 1 commit into
python:masterfrom
methane:fix-buildbot

Conversation

@methane

@methanemethane commented Jun 17, 2020•
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

@methanemethane added type-bug An unexpected behavior, bug, or error skip news labels Jun 17, 2020
@methane
methane requested a review from vstinnerJune 17, 2020 12:31
@methanemethane added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed CLA signed labels Jun 17, 2020
@bedevere-bot

bedevere-bot commented Jun 17, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @methane for commit 8b54cb7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 17, 2020
vstinner
vstinner approved these changes Jun 17, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I suggest to change the commit title to "Make unicodeobject.h C89 compatible".

Comment threadInclude/cpython/unicodeobject.h
Py_UNICODE_FILL(Py_UNICODE *target, Py_UNICODE value, Py_ssize_t length) {
for (Py_ssize_t i = 0; i < length; i++) {
Py_ssize_t i;
for (i = 0; i < length; i++) {

@vstinnervstinnerJun 17, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes me sad :-( But well, as I wrote in the issue, I think that it's a good practice to try to keep C89 support for the public C API.

@methanemethane changed the title bpo-36346: Fix buildbotsbpo-36346: Make unicodeobject.h C89 compatibleJun 17, 2020
@methane
methane merged commit 8e34e92 into python:masterJun 17, 2020
@methane
methane deleted the fix-buildbot branch June 17, 2020 14:43
methane added a commit to methane/cpython that referenced this pull request Jun 17, 2020
@methane
bpo-36346: Make unicodeobject.h C89 compatible (pythonGH-20934)
5fc4e4b
@bedevere-botbedevere-bot mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip newstype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane@bedevere-bot@vstinner@the-knights-who-say-ni