Skip to content

bpo-40968: Send http/1.1 ALPN extension - #20959

Merged
tiran merged 1 commit into
python:masterfrom
tiran:bpo-40968-alpn
Nov 13, 2020
Merged

bpo-40968: Send http/1.1 ALPN extension#20959
tiran merged 1 commit into
python:masterfrom
tiran:bpo-40968-alpn

Conversation

@tiran

@tirantiran commented Jun 18, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@tirantiran added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Jun 18, 2020
@tiran

tiran commented Jun 18, 2020

Copy link
Copy Markdown
MemberAuthor
  • It's a low-risk change. cURL has been setting the ALPN indicator for years.
  • The change fixes a problem with servers that require an ALPN extension to indicate HTTP version.
  • Need to figure out how to test the change.

@paulmenzelpaulmenzel mentioned this pull request Jun 18, 2020
Closed
@tirantiran mentioned this pull request Jun 18, 2020
Closed
sethmlarson
sethmlarson reviewed Jun 18, 2020
View reviewed changes
Comment threadLib/http/client.py Outdated

@sethmlarsonsethmlarsonJun 18, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are this comment and the functionality out of sync here since http_vsn_str can be HTTP/1.0, etc? http/1.1, http/1.0, and http/0.9 are all valid ALPN protocol IDs but the comment and changelogs only mention 1.1. This might be fine anyways but something I noticed.

@tirantiranNov 13, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now checking _http_vsn and only send the ALPN extension when the version is 11 (HTTP/1.1).

@tiran
bpo-40968: Send http/1.1 ALPN extension
977ec2a
Signed-off-by: Christian Heimes <christian@python.org>
@tirantiran added type-feature A feature request or enhancement and removed needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Nov 13, 2020
@tiran
tiran marked this pull request as ready for review November 13, 2020 09:05
sethmlarson
sethmlarson approved these changes Nov 13, 2020
View reviewed changes

@sethmlarsonsethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiran
tiran merged commit f97406b into python:masterNov 13, 2020
@bedevere-bot

bedevere-bot commented Nov 13, 2020

Copy link
Copy Markdown

@tiran: Please replace # with GH- in the commit message next time. Thanks!

@tiran
tiran deleted the bpo-40968-alpn branch November 13, 2020 15:37
@handlerbothandlerbot mentioned this pull request Mar 5, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@tiran@adorilson
bpo-40968: Send http/1.1 ALPN extension (python#20959)
a393bca
Signed-off-by: Christian Heimes <christian@python.org>
@pmenzelpmenzelmannequin mentioned this pull request May 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethmlarsonsethmlarsonsethmlarson approved these changes

Assignees

No one assigned

Labels

type-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@bedevere-bot@sethmlarson@the-knights-who-say-ni