Skip to content

bpo-40077: Convert _bz2 module to use PyType_FromSpec - #20960

Merged
corona10 merged 9 commits into
python:masterfrom
corona10:bpo-40077-bz2
Jun 19, 2020
Merged

bpo-40077: Convert _bz2 module to use PyType_FromSpec#20960
corona10 merged 9 commits into
python:masterfrom
corona10:bpo-40077-bz2

Conversation

@corona10

@corona10corona10 commented Jun 18, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10
corona10 requested a review from vstinnerJune 18, 2020 10:05
corona10
corona10 commented Jun 18, 2020
View reviewed changes
Comment threadLib/test/test_bz2.py Outdated
@corona10
corona10 marked this pull request as draft June 18, 2020 13:15
@vstinner

vstinner commented Jun 18, 2020

Copy link
Copy Markdown
Member

I don't think that it should be possible to serialize a Compressor or Decompressor object. There is no getstate/setstate or reduce methods which would serialize attributes only accessible in C. More generally, I don't think that it would be useful, nor needed.

See https://bugs.python.org/issue40077#msg371813

vstinner
vstinner reviewed Jun 18, 2020
View reviewed changes
Comment threadModules/_bz2module.c Outdated
@corona10
corona10 marked this pull request as ready for review June 18, 2020 17:04
@corona10

corona10 commented Jun 18, 2020

Copy link
Copy Markdown
MemberAuthor

@vstinner Thanks updated!

@corona10
corona10 requested a review from vstinnerJune 18, 2020 17:06
vstinner
vstinner reviewed Jun 18, 2020
View reviewed changes
Comment threadModules/_bz2module.c Outdated
vstinner
vstinner reviewed Jun 19, 2020
View reviewed changes
Comment threadModules/_bz2module.c
@corona10
corona10 requested a review from vstinnerJune 19, 2020 14:21
vstinner
vstinner reviewed Jun 19, 2020
View reviewed changes
Comment threadModules/_bz2module.c Outdated
Comment threadModules/_bz2module.c Outdated
@corona10
corona10 requested a review from vstinnerJune 19, 2020 14:54
vstinner
vstinner approved these changes Jun 19, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10corona10 reopened this Jun 19, 2020
@corona10
corona10 merged commit ec68918 into python:masterJun 19, 2020
@corona10
corona10 deleted the bpo-40077-bz2 branch June 19, 2020 15:56
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@corona10@fasihahmad
bpo-40077: Convert _bz2 module to use PyType_FromSpec (pythonGH-20960)
4a9bcd5
@corona10corona10 mentioned this pull request Jun 27, 2022
Closed
@sergey-miryanovsergey-miryanov mentioned this pull request Sep 18, 2025
Merged
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@vstinner@the-knights-who-say-ni@bedevere-bot