Skip to content

bpo-1635741: Port faulthandler module to multiphase initialization - #21294

Merged
corona10 merged 2 commits into
python:masterfrom
corona10:bpo-1635741-fault
Jul 3, 2020
Merged

bpo-1635741: Port faulthandler module to multiphase initialization#21294
corona10 merged 2 commits into
python:masterfrom
corona10:bpo-1635741-fault

Conversation

@corona10

@corona10corona10 commented Jul 3, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10
corona10 requested a review from vstinnerJuly 3, 2020 14:34
corona10
corona10 commented Jul 3, 2020
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner@shihai1991 PTAL :)

vstinner
vstinner approved these changes Jul 3, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems like your PR introduces a compiler warning on the slots:

"initialization from incompatible pointer type [-Wincompatible-pointer-types]"

It may be good to fix it first.

Comment threadModules/faulthandler.c Outdated
@corona10

corona10 commented Jul 3, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

"initialization from incompatible pointer type [-Wincompatible-pointer-types]"

Yeah, it should be PyModuleDef_Slot, not PyType_Slot, it was my mistake.
I've fixed the PR, and after the test is passed, I will merge this PR

@vstinner

vstinner commented Jul 3, 2020

Copy link
Copy Markdown
Member

Yeah, it should be PyModuleDef_Slot, not PyType_Slot

Ooops :-)

@corona10corona10 closed this Jul 3, 2020
@corona10corona10 reopened this Jul 3, 2020
@corona10corona10 mentioned this pull request Jul 3, 2020
Merged
@corona10corona10 closed this Jul 3, 2020
@corona10corona10 reopened this Jul 3, 2020
@corona10
corona10 merged commit c0b214b into python:masterJul 3, 2020
@corona10
corona10 deleted the bpo-1635741-fault branch July 3, 2020 16:36
@vstinner

vstinner commented Jul 3, 2020

Copy link
Copy Markdown
Member

Thanks for taking care of "my" little module :-)

@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@vstinner@the-knights-who-say-ni@bedevere-bot