Skip to content

bpo-37363: Add audit events to the http.client module - #21321

Merged
matrixise merged 4 commits into
python:masterfrom
gousaiyang:audit-http-client
Apr 23, 2021
Merged

bpo-37363: Add audit events to the http.client module#21321
matrixise merged 4 commits into
python:masterfrom
gousaiyang:audit-http-client

Conversation

@gousaiyang

@gousaiyanggousaiyang commented Jul 4, 2020

Copy link
Copy Markdown
Contributor

@matrixise

Copy link
Copy Markdown
Member

Hello @gousaiyang

Thank you for your contribution, really appreciated.

Could you add some tests, for example, you could check in Lib/tests/test_audit.py if you need some pointers.

@gousaiyang

Copy link
Copy Markdown
ContributorAuthor

Hi @matrixise. If you had time could you review this PR again? Thanks!

@matrixisematrixise self-assigned this Apr 22, 2021
@matrixise

Copy link
Copy Markdown
Member

Hi @gousaiyang

Your PR is on my list. I will check it asap.

Thank you

@matrixise
matrixise merged commit 927b841 into python:masterApr 23, 2021
@matrixise

Copy link
Copy Markdown
Member

Just forgot to approve the branch, but everything seems fine to me.

@gousaiyang Thank you for your contribution, this one will be only in 3.10

@gousaiyang
gousaiyang deleted the audit-http-client branch April 23, 2021 18:24
@zoobazooba mentioned this pull request Nov 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@gousaiyang@matrixise@the-knights-who-say-ni@bedevere-bot