Uh oh!
There was an error while loading. Please reload this page.
bpo-26205: Specify the number of nested scopes - #21324
Merged
Merged
Conversation
terryjreedy
requested changes
Jul 6, 2020
terryjreedy
left a comment
Member
There was a problem hiding this comment.
I approve with the requested change.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Jul 6, 2020
When you're done making the requested changes, leave the comment: |
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy
approved these changes
Jul 6, 2020
Member
Please merge and backport with a changed ('activated') title, as I discussed on #21340. |
miss-islington
commented
Jul 6, 2020
Contributor
Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 6, 2020
* Clarify number of scopes * Indicate 3 or 4 Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 9ed3cd8) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
bedevere-bot
commented
Jul 6, 2020
GH-21341 is a backport of this pull request to the 3.9 branch. |
bedevere-bot
commented
Jul 6, 2020
GH-21342 is a backport of this pull request to the 3.8 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 6, 2020
* Clarify number of scopes * Indicate 3 or 4 Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 9ed3cd8) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
nanjekyejoannah
commented
Jul 6, 2020
ContributorAuthor
Thanks for the review @terryjreedy |
nanjekyejoannah added a commit
that referenced
this pull request
Jul 6, 2020
* Clarify number of scopes * Indicate 3 or 4 Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 9ed3cd8) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com> Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
nanjekyejoannah added a commit
that referenced
this pull request
Jul 6, 2020
* Clarify number of scopes * Indicate 3 or 4 Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 9ed3cd8) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com> Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
shihai1991 pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jul 6, 2020
* Clarify number of scopes * Indicate 3 or 4 Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue26205