Uh oh!
There was an error while loading. Please reload this page.
bpo-41273: asyncio's proactor read transport's better performance by using recv_into instead of recv - #21442
Merged
Merged
Conversation
kk456852
approved these changes
Jul 11, 2020
By using recv_into instead of recv we do not allocate a new buffer each time _loop_reading calls recv. This betters performance for any stream using proactor (basically any asyncio stream on windows).
By doubling the read buffer size we get better performance.
1st1
approved these changes
Jul 14, 2020
bedevere-bot
commented
Jul 14, 2020
@1st1: Please replace |
1st1
commented
Jul 14, 2020
Member
Thank you! |
shihai1991 pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 4, 2020
…using recv_into instead of recv (python#21442) * bpo-41273: Proactor transport read loop to use recv_into By using recv_into instead of recv we do not allocate a new buffer each time _loop_reading calls recv. This betters performance for any stream using proactor (basically any asyncio stream on windows). * bpo-41273: Double proactor read transport buffer size By doubling the read buffer size we get better performance.
shihai1991 pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
…using recv_into instead of recv (python#21442) * bpo-41273: Proactor transport read loop to use recv_into By using recv_into instead of recv we do not allocate a new buffer each time _loop_reading calls recv. This betters performance for any stream using proactor (basically any asyncio stream on windows). * bpo-41273: Double proactor read transport buffer size By doubling the read buffer size we get better performance.
xzy3 pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
…using recv_into instead of recv (python#21442) * bpo-41273: Proactor transport read loop to use recv_into By using recv_into instead of recv we do not allocate a new buffer each time _loop_reading calls recv. This betters performance for any stream using proactor (basically any asyncio stream on windows). * bpo-41273: Double proactor read transport buffer size By doubling the read buffer size we get better performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41273
I got about 150% better performance on
await reader.read()using this branch (Windows only).The way I tested was writing a server / client:
server.py:client.py: