Skip to content

gh-85525: Indicate supported sound header formats - #21575

Merged
nanjekyejoannah merged 4 commits into
python:mainfrom
nanjekyejoannah:sndhdr
Oct 15, 2022
Merged

gh-85525: Indicate supported sound header formats#21575
nanjekyejoannah merged 4 commits into
python:mainfrom
nanjekyejoannah:sndhdr

Conversation

@nanjekyejoannah

@nanjekyejoannahnanjekyejoannah commented Jul 21, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

merwok
merwok reviewed Jul 24, 2020
View reviewed changes
Comment threadDoc/library/sndhdr.rst
Comment threadDoc/library/sndhdr.rst
@nanjekyejoannahnanjekyejoannah mentioned this pull request Apr 11, 2022
Closed
@hugovk

hugovk commented Apr 11, 2022

Copy link
Copy Markdown
Member

Note the sndhdr module is deprecated in 3.11 and set for removal in 3.13.

See PEP 594 – Removing dead batteries from the standard library and #91217.

@AlexWaygood

AlexWaygood commented Apr 12, 2022

Copy link
Copy Markdown
Member

Note the sndhdr module is deprecated in 3.11 and set for removal in 3.13.

See PEP 594 – Removing dead batteries from the standard library and #91217.

Nonetheless, this does look like a relatively simple docs enhancement that would be quite nice to have. It would be nice if it could get over the line.

@JelleZijlstra
JelleZijlstra self-requested a review April 12, 2022 13:49
@JelleZijlstraJelleZijlstra changed the title bpo-41353: Indicate supported sound header formatsgh-85525: Indicate supported sound header formatsApr 12, 2022
@JelleZijlstra
JelleZijlstra removed their request for review April 13, 2022 02:56
@nanjekyejoannah

nanjekyejoannah commented Apr 13, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@willingc can you help review this and see if it can be merged?

hugovk
hugovk reviewed Apr 13, 2022
View reviewed changes
Comment threadDoc/library/sndhdr.rst
Comment threadDoc/library/sndhdr.rst Outdated
@AA-TurnerAA-Turner added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes docs Documentation in the Doc dir and removed CLA signed labels Jun 7, 2022
@AA-Turner

AA-Turner commented Jun 7, 2022

Copy link
Copy Markdown
Member

I agree with @AlexWaygood that this would be useful to consumers of the module for 3.10 through 3.12 -- I've no comments beyond Hugo's points though.

A

@github-actions

github-actionsBot commented Jul 30, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Jul 30, 2022
@nanjekyejoannah
nanjekyejoannah merged commit 05c042e into python:mainOct 15, 2022
@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Sorry @nanjekyejoannah, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.11

@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Sorry, @nanjekyejoannah, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.10

@AlexWaygoodAlexWaygood removed the needs backport to 3.11 only security fixes label Oct 15, 2022
@AlexWaygoodAlexWaygood added the needs backport to 3.11 only security fixes label Oct 15, 2022
@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Sorry @nanjekyejoannah, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.11

@AlexWaygoodAlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 15, 2022
@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2022
@nanjekyejoannah@miss-islington
pythongh-85525: Indicate supported sound header formats (pythonGH-21575)
26f058c
* Indicate supported sound header formats
* modify file names
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 05c042e)
Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Oct 15, 2022

Copy link
Copy Markdown

GH-98277 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Oct 15, 2022
miss-islington added a commit that referenced this pull request Oct 15, 2022
@miss-islington@nanjekyejoannah
gh-85525: Indicate supported sound header formats (GH-21575)
232a988
* Indicate supported sound header formats
* modify file names
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 05c042e)
Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
merwok
merwok reviewed Oct 15, 2022
View reviewed changes
Comment threadDoc/library/sndhdr.rst
@ZeroIntensityZeroIntensity removed the needs backport to 3.10 only security fixes label Feb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwokmerwokmerwok left review comments
@hugovkhugovkhugovk left review comments

Assignees

@nanjekyejoannahnanjekyejoannah

Labels

docsDocumentation in the Doc dirskip newsstaleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@nanjekyejoannah@hugovk@AlexWaygood@AA-Turner@miss-islington@bedevere-bot@merwok@the-knights-who-say-ni@ZeroIntensity@JelleZijlstra