bpo-41440: add os.cpu_count() support for VxWorks RTOS by pxinwr · Pull Request #21685 · python/cpython

pxinwr · 2020-07-30T07:17:01Z

VxWorks RTOS provides API vxCpuEnabledGet() to get the set of running CPUs in the system. The return value of vxCpuEnabledGet() is the type cpuset_t defined as shown below. Every bit in the cpuset_t represents the individual CPU No. That is bit 0 corresponds to cpu0, bit 1 corresponds to cpu1, etc. So counting the ones count with __builtin_popcount will get the running CPU count.

typedef unsigned int cpuset_t;

https://bugs.python.org/issue41440

bedevere-bot · 2020-07-30T14:32:55Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

pxinwr · 2020-07-31T06:02:53Z

I have made the requested changes; please review again

bedevere-bot · 2020-07-31T06:02:56Z

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

corona10

nit change

bedevere-bot · 2020-07-31T06:59:38Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

pxinwr · 2020-07-31T08:24:16Z

I have made the requested changes; please review again

bedevere-bot · 2020-07-31T08:24:19Z

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

bedevere-bot · 2020-07-31T12:47:25Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

This reverts commit 88e7cea.

pxinwr · 2020-08-01T13:48:11Z

I have made the requested changes; please review again

bedevere-bot · 2020-08-01T13:48:15Z

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

Co-authored-by: Victor Stinner <vstinner@python.org>

pxinwr · 2020-08-10T02:01:52Z

@corona10 Thanks for merging it.

add os.cpu_count() support for VxWorks RTOS
70b1229

the-knights-who-say-ni added the CLA signed label Jul 30, 2020

bedevere-bot added the awaiting review label Jul 30, 2020

Rerun the CI
42f7f57

corona10 requested changes Jul 30, 2020
View reviewed changes

Comment threadModules/posixmodule.c Outdated

bedevere-bot added awaiting changes and removed awaiting review labels Jul 30, 2020

corona10 requested a review from vstinner July 30, 2020 14:33

replace __builtin_popcount with _Py_popcount32
ff31665

bedevere-bot added awaiting change review and removed awaiting changes labels Jul 31, 2020

bedevere-bot requested a review from corona10 July 31, 2020 06:02

corona10 requested changes Jul 31, 2020
View reviewed changes

Comment threadMisc/NEWS.d/next/Library/2020-07-30-14-56-58.bpo-41440.rju34k.rst Outdated

bedevere-bot removed the awaiting change review label Jul 31, 2020

bedevere-bot added the awaiting changes label Jul 31, 2020

pxinwrand others added 3 commits July 31, 2020 15:07

rerun the ci
3c85faa

Update Misc/NEWS.d/next/Library/2020-07-30-14-56-58.bpo-41440.rju34k.rst
0f52c97
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

update What's New
88e7cea

bedevere-bot added awaiting change review and removed awaiting changes labels Jul 31, 2020

bedevere-bot requested a review from corona10 July 31, 2020 08:24

corona10 requested changes Jul 31, 2020
View reviewed changes

Comment threadDoc/whatsnew/3.10.rst Outdated

bedevere-bot added awaiting changes and removed awaiting change review labels Jul 31, 2020

pxinwr added 2 commits August 1, 2020 21:33

Revert "update What's New"
9249226
This reverts commit 88e7cea.

move changelog in whatsnew
3c1c4bc

bedevere-bot added awaiting change review and removed awaiting changes labels Aug 1, 2020

bedevere-bot requested a review from corona10 August 1, 2020 13:48

corona10 approved these changes Aug 2, 2020
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Aug 2, 2020

vstinner reviewed Aug 3, 2020
View reviewed changes

Comment threadModules/posixmodule.c Outdated
Comment threadDoc/whatsnew/3.10.rst

pxinwrand others added 2 commits August 4, 2020 10:36

Update Modules/posixmodule.c
2fc1568
Co-authored-by: Victor Stinner <vstinner@python.org>

Polish Doc/whatsnew/3.10.rst
f8766a7
Co-authored-by: Victor Stinner <vstinner@python.org>

corona10 requested a review from vstinner August 5, 2020 08:44

corona10 merged commit 3405e05 into python:masterAug 7, 2020

bedevere-bot removed the awaiting merge label Aug 7, 2020

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
bpo-41440: add os.cpu_count() support for VxWorks RTOS (pythonGH-21685)
013bf40

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-41440: add os.cpu_count() support for VxWorks RTOS (pythonGH-21685)
3d5f967

pxinwr deleted the fix-issue-31904-cpucount branch July 12, 2021 09:41

Uh oh!

Uh oh!

Conversation

pxinwr commented Jul 30, 2020• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jul 30, 2020

Uh oh!

pxinwr commented Jul 31, 2020

Uh oh!

bedevere-bot commented Jul 31, 2020

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Jul 31, 2020

Uh oh!

pxinwr commented Jul 31, 2020

Uh oh!

bedevere-bot commented Jul 31, 2020

Uh oh!

Uh oh!

bedevere-bot commented Jul 31, 2020

Uh oh!

pxinwr commented Aug 1, 2020

Uh oh!

bedevere-bot commented Aug 1, 2020

Uh oh!

Uh oh!

Uh oh!

pxinwr commented Aug 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pxinwr commented Jul 30, 2020•
edited by bedevere-bot
Loading