Skip to content

bpo-1635741: port blake2 module to multi-phase init - #21856

Merged
vstinner merged 11 commits into
python:masterfrom
koubaa:bpo-1635741-blake2
Sep 2, 2020
Merged

bpo-1635741: port blake2 module to multi-phase init#21856
vstinner merged 11 commits into
python:masterfrom
koubaa:bpo-1635741-blake2

Conversation

@koubaa

@koubaakoubaa commented Aug 13, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@koubaa
koubaa requested a review from tiran as a code ownerAugust 13, 2020 12:23
@koubaakoubaa mentioned this pull request Aug 13, 2020
Merged
@koubaa
koubaaforce-pushed the bpo-1635741-blake2 branch from d282ca9 to abb51feCompareAugust 21, 2020 23:49
@koubaa

koubaa commented Aug 29, 2020

Copy link
Copy Markdown
ContributorAuthor

@vstinner@shihai1991 This is ready for review

vstinner
vstinner reviewed Aug 29, 2020
View reviewed changes
Comment threadModules/_blake2/blake2b_impl.c Outdated
Comment threadModules/_blake2/blake2module.c Outdated
Comment threadModules/_blake2/blake2module.c Outdated
Comment threadModules/_blake2/blake2module.c Outdated
Comment threadModules/_blake2/blake2s_impl.c Outdated
vstinner
vstinner approved these changes Sep 1, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor suggestion on the NEWS entry (please update it).

But right now, I cannot merge the PR: https://mail.python.org/archives/list/python-dev@python.org/thread/KMXK6BQWQZRR2TGVRLECMR7CUVIVTUMQ/

Please ping me when the workflow will be repaired, so I will merge your PR.

Comment threadMisc/NEWS.d/next/Core and Builtins/2020-08-13-07-18-05.bpo-1635741.FC13e7.rst Outdated
@koubaa

koubaa commented Sep 1, 2020

Copy link
Copy Markdown
ContributorAuthor

@vstinner looks like the doc issue is fixed in the CI.

@vstinner
vstinner merged commit a7f0268 into python:masterSep 2, 2020
@vstinner

vstinner commented Sep 2, 2020

Copy link
Copy Markdown
Member

Merged, thanks @koubaa.

@corona10corona10 mentioned this pull request Sep 10, 2020
Closed
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@koubaa@xzy3-cdc
bpo-1635741: Port _blake2 module to multi-phase init (pythonGH-21856)
79cb7a5
Port the _blake2 extension module to the multi-phase
initialization API (PEP 489).
@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@tirantiranAwaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koubaa@vstinner@the-knights-who-say-ni@bedevere-bot