Skip to content

bpo-1635741 port cmath to multi-phase init (pep 489) - #22165

Merged
vstinner merged 3 commits into
python:masterfrom
koubaa:bpo-1635741-cmath
Sep 10, 2020
Merged

bpo-1635741 port cmath to multi-phase init (pep 489)#22165
vstinner merged 3 commits into
python:masterfrom
koubaa:bpo-1635741-cmath

Conversation

@koubaa

@koubaakoubaa commented Sep 9, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@koubaa

koubaa commented Sep 9, 2020

Copy link
Copy Markdown
ContributorAuthor

@vstinner@shihai1991@corona10 please review

vstinner
vstinner reviewed Sep 9, 2020
View reviewed changes
Comment threadModules/cmathmodule.c Outdated
Comment threadModules/cmathmodule.c Outdated
vstinner
vstinner approved these changes Sep 10, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
vstinner merged commit f76d894 into python:masterSep 10, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@koubaa@xzy3-cdc
bpo-1635741: Port cmath to multi-phase init (PEP 489) (pythonGH-22165)
395142d
@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koubaa@vstinner@the-knights-who-say-ni@bedevere-bot