[doc] Leverage the fact that the actual types can now be indexed for typing by andresdelfino · Pull Request #22340 · python/cpython

andresdelfino · 2020-09-21T14:29:36Z

This shows users that they can use the actual types. Using deprecated types is confusing.

This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place.

This should be backported to 3.9.

Automerge-Triggered-By: @gvanrossum

gvanrossum

Thanks! At first I was hesitant to approve this, because people will want to write code that's backwards compatible for a few versions, but they should just read the old docs...

gvanrossum · 2020-09-27T01:25:41Z

Travis reporting is stuck, and it prevents me from overriding, so I'm going to close and reopen in the hope that fixes it. (There's quite a chance that it doesn't.)

gvanrossum · 2020-09-27T03:55:11Z

@Mariatta What's the trick to landing this?

andresdelfino · 2020-09-27T16:11:38Z

@gvanrossum it may be the Travis CI build, which is queued. It seems there was a problem with Travis reporting the build state to GitHub, as all jobs are done in Travis:

https://travis-ci.com/github/python/cpython/builds/185656276

GitHub is waiting for that build to end since I opened the PR.

gvanrossum · 2020-09-27T18:35:40Z

If you can, read the issue that references this. There’s a GitHub bug that prevents it from seeing the reported status, and some kind of super permission that I don’t have is needed to bypass that. :-(

miss-islington · 2020-09-27T18:49:42Z

@andresdelfino: Status check is done, and it's a success ✅ .

miss-islington · 2020-09-27T18:49:42Z

@andresdelfino: Status check is done, and it's a success ✅ .

miss-islington · 2020-09-27T18:49:43Z

Sorry, I can't merge this PR. Reason: 2 of 4 required status checks have not succeeded: 1 expected..

miss-islington · 2020-09-27T18:49:44Z

Sorry, I can't merge this PR. Reason: 2 of 4 required status checks have not succeeded: 1 expected..

andresdelfino · 2020-09-27T18:50:42Z

Just pushed an empty commit to try to unlock the Travis build.

miss-islington · 2020-09-27T19:07:03Z

@andresdelfino: Status check is done, and it's a success ✅ .

miss-islington · 2020-09-27T19:07:07Z

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@gvanrossum

…typing (pythonGH-22340) This shows users that they can use the actual types. Using deprecated types is confusing. This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place. This should be backported to 3.9. Automerge-Triggered-By: @gvanrossum (cherry picked from commit d9ab95f) Co-authored-by: Andre Delfino <adelfino@gmail.com>

bedevere-bot · 2020-09-27T19:07:32Z

GH-22430 is a backport of this pull request to the 3.9 branch.

@gvanrossum

…typing (GH-22340) This shows users that they can use the actual types. Using deprecated types is confusing. This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place. This should be backported to 3.9. Automerge-Triggered-By: @gvanrossum (cherry picked from commit d9ab95f) Co-authored-by: Andre Delfino <adelfino@gmail.com>

* origin/master: (113 commits) bpo-41773: Raise exception for non-finite weights in random.choices(). (pythonGH-22441) bpo-41873: Add vectorcall for float() (pythonGH-22432) bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428) bpo-41842: Add codecs.unregister() function (pythonGH-22360) bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433) bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337) bpo-41870: Use PEP 590 vectorcall to speed up bool() (pythonGH-22427) [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340) bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417) bpo-41858: Clarify line in optparse doc (pythonGH-22407) Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424) bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415) bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416) Fix logging error message (pythonGH-22410) bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395) bpo-41775: Make 'IDLE Shell' the shell title (python#22399) bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388) bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387) bpo-41833: threading.Thread now uses the target name (pythonGH-22357) bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633) ...

@gvanrossum

…H-22524) This changes a few occurrences left behind by #22340. Automerge-Triggered-By: @gvanrossum

@gvanrossum

…ythonGH-22524) This changes a few occurrences left behind by pythonGH-22340. Automerge-Triggered-By: @gvanrossum (cherry picked from commit 7f54e56) Co-authored-by: Andre Delfino <adelfino@gmail.com>

@gvanrossum

…H-22524) This changes a few occurrences left behind by GH-22340. Automerge-Triggered-By: @gvanrossum (cherry picked from commit 7f54e56) Co-authored-by: Andre Delfino <adelfino@gmail.com>

@gvanrossum

…typing (pythonGH-22340) This shows users that they can use the actual types. Using deprecated types is confusing. This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place. This should be backported to 3.9. Automerge-Triggered-By: @gvanrossum (cherry picked from commit d9ab95f) Co-authored-by: Andre Delfino <adelfino@gmail.com>

@gvanrossum

…ythonGH-22524) This changes a few occurrences left behind by pythonGH-22340. Automerge-Triggered-By: @gvanrossum (cherry picked from commit 7f54e56) Co-authored-by: Andre Delfino <adelfino@gmail.com>

@gvanrossum

…typing (pythonGH-22340) This shows users that they can use the actual types. Using deprecated types is confusing. This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place. This should be backported to 3.9. Automerge-Triggered-By: @gvanrossum

@gvanrossum

…ythonGH-22524) This changes a few occurrences left behind by python#22340. Automerge-Triggered-By: @gvanrossum

Use new generic types
77b99a6

andresdelfino requested review from gvanrossum and ilevkivskyi as code owners September 21, 2020 14:29

the-knights-who-say-ni added the CLA signed label Sep 21, 2020

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 21, 2020

andresdelfino changed the title ~~[doc] Take advantage that actual types can be indexed for typing~~[doc] Leverage the fact that the actual types can now be indexed for typingSep 21, 2020

Restore order
fa7bbed

gvanrossum approved these changes Sep 27, 2020
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Sep 27, 2020

gvanrossum added 🤖 automerge skip issue skip news labels Sep 27, 2020

gvanrossum closed this Sep 27, 2020

gvanrossum reopened this Sep 27, 2020

gvanrossum removed the request for review from ilevkivskyi September 27, 2020 01:26

Fix Travis build
dceacb3

miss-islington merged commit d9ab95f into python:masterSep 27, 2020

bedevere-bot removed the awaiting merge label Sep 27, 2020

andresdelfino deleted the use_actual_generic_types branch September 27, 2020 19:07

bedevere-bot removed the needs backport to 3.9 label Sep 27, 2020

andresdelfino mentioned this pull request Oct 3, 2020
[doc] Use list[int] instead of List[int] (etc.) in a few more places #22524
Merged

miss-islington pushed a commit that referenced this pull request Oct 3, 2020
[doc] Use list[int] instead of List[int] (etc.) in a few more places (G…
7f54e56
…H-22524) This changes a few occurrences left behind by #22340. Automerge-Triggered-By: @gvanrossum

miss-islington mentioned this pull request Oct 3, 2020
[3.9] [doc] Use list[int] instead of List[int] (etc.) in a few more places (GH-22524) #22531
Merged

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
[doc] Use list[int] instead of List[int] (etc.) in a few more places (p…
39b5ae0
…ythonGH-22524) This changes a few occurrences left behind by python#22340. Automerge-Triggered-By: @gvanrossum

Uh oh!

Uh oh!

Conversation

andresdelfino commented Sep 21, 2020• edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum commented Sep 27, 2020

Uh oh!

gvanrossum commented Sep 27, 2020

Uh oh!

andresdelfino commented Sep 27, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gvanrossum commented Sep 27, 2020

Uh oh!

miss-islington commented Sep 27, 2020

Uh oh!

miss-islington commented Sep 27, 2020

Uh oh!

miss-islington commented Sep 27, 2020

Uh oh!

miss-islington commented Sep 27, 2020

Uh oh!

andresdelfino commented Sep 27, 2020

Uh oh!

miss-islington commented Sep 27, 2020

Uh oh!

miss-islington commented Sep 27, 2020

Uh oh!

bedevere-bot commented Sep 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

andresdelfino commented Sep 21, 2020•
edited by miss-islington
Loading

andresdelfino commented Sep 27, 2020•
edited
Loading