Skip to content

bpo-41861: Convert _sqlite3 RowType and StatementType to heap types - #22444

Merged
vstinner merged 3 commits into
python:masterfrom
erlend-aasland:fix-bpo-41861/row-and-stmt
Oct 1, 2020
Merged

bpo-41861: Convert _sqlite3 RowType and StatementType to heap types#22444
vstinner merged 3 commits into
python:masterfrom
erlend-aasland:fix-bpo-41861/row-and-stmt

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Sep 28, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Part 3 of bpo-41861, @vstinner

Tested for ref. leaks with ./python.exe -m test -F -r -j1 -R 3:10 test_sqlite

https://bugs.python.org/issue41861

vstinner
vstinner approved these changes Sep 28, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you remove Py_TPFLAGS_HEAPTYPE.

Comment threadModules/_sqlite/statement.c Outdated
@erlend-aasland

erlend-aasland commented Sep 28, 2020

Copy link
Copy Markdown
ContributorAuthor

LGTM if you remove Py_TPFLAGS_HEAPTYPE.

See 6d22771

vstinner
vstinner approved these changes Sep 28, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland

erlend-aasland commented Sep 29, 2020

Copy link
Copy Markdown
ContributorAuthor

@vstinner Any idea why the macOS tests are failing? I'm unable to see the details (perhaps due to a recent change in the CI?). I'm tempted to just re-run the checks.

@vstinner

vstinner commented Oct 1, 2020

Copy link
Copy Markdown
Member

@vstinner Any idea why the macOS tests are failing? I'm unable to see the details (perhaps due to a recent change in the CI?). I'm tempted to just re-run the checks.

I don't see any logs. It looks like a bug on the GitHub Action. I don't know how to debug such issue.

These checks are not mandatory, you can safely ignore it.

@vstinner
vstinner merged commit 9031bd4 into python:masterOct 1, 2020
@vstinner

vstinner commented Oct 1, 2020

Copy link
Copy Markdown
Member

Merged, thanks. Next? :-)

@erlend-aasland

erlend-aasland commented Oct 1, 2020

Copy link
Copy Markdown
ContributorAuthor

Merged, thanks. Next? :-)

Thanks, coming right up! :)

@erlend-aasland
erlend-aasland deleted the fix-bpo-41861/row-and-stmt branch October 1, 2020 13:25
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Erlend Egeberg Aasland@xzy3-cdc
bpo-41861: Convert _sqlite3 RowType and StatementType to heap types (p…
b5c008f
…ythonGH-22444)
@erlend-aaslanderlend-aasland mentioned this pull request Aug 20, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@vstinner@the-knights-who-say-ni@bedevere-bot