Skip to content

bpo-42047: DragonFlyBSD thread native id support. - #22714

Merged
erlend-aasland merged 8 commits into
python:mainfrom
devnexen:dfbsd_build_fix
May 18, 2022
Merged

bpo-42047: DragonFlyBSD thread native id support.#22714
erlend-aasland merged 8 commits into
python:mainfrom
devnexen:dfbsd_build_fix

Conversation

@devnexen

@devnexendevnexen commented Oct 15, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Fidget-Spinner
Fidget-Spinner reviewed Oct 16, 2020
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor nitpick on news

Comment threadMisc/NEWS.d/next/Library/2020-10-15-18-37-12.bpo-42047.XDdoSF.rst Outdated
@devnexen@Fidget-Spinner
Update Misc/NEWS.d/next/Library/2020-10-15-18-37-12.bpo-42047.XDdoSF.rst
ba9f74a
Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>
@github-actions

github-actionsBot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@devnexen

devnexen commented Dec 16, 2020

Copy link
Copy Markdown
ContributorAuthor

ping :)

@github-actionsgithub-actionsBot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020
erlend-aasland
erlend-aasland reviewed May 18, 2022
View reviewed changes
Comment threadInclude/pythread.h Outdated
vstinner
vstinner reviewed May 18, 2022
View reviewed changes
Comment threadInclude/pythread.h Outdated
@erlend-aasland@vstinner
Break long line
5a54ad2
Co-authored-by: Victor Stinner <vstinner@python.org>
@erlend-aasland

erlend-aasland commented May 18, 2022

Copy link
Copy Markdown
Contributor

Please also update the availability annotation of get_native_id in the docs:

  • Doc/library/_thread.rst
  • Doc/library/threading.rst

See gh-13624 for inspiration :)

erlend-aasland
erlend-aasland reviewed May 18, 2022
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2020-10-15-18-37-12.bpo-42047.XDdoSF.rst Outdated
erlend-aasland
erlend-aasland reviewed May 18, 2022
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2020-10-15-18-37-12.bpo-42047.XDdoSF.rst Outdated
@erlend-aaslanderlend-aasland self-assigned this May 18, 2022
erlend-aasland
erlend-aasland requested changes May 18, 2022
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve #22714 (comment)

@bedevere-bot

bedevere-bot commented May 18, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

erlend-aasland
erlend-aasland reviewed May 18, 2022
View reviewed changes
Comment threadDoc/library/_thread.rst
@devnexen

devnexen commented May 18, 2022

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented May 18, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@erlend-aasland, @Fidget-Spinner: please review the changes made to this pull request.

@erlend-aasland
erlend-aasland merged commit 9a1adf2 into python:mainMay 18, 2022
@erlend-aasland

erlend-aasland commented May 18, 2022

Copy link
Copy Markdown
Contributor

Thanks, @devnexen!

@erlend-aaslanderlend-aasland mentioned this pull request May 18, 2022
Closed
@vstinner

vstinner commented May 18, 2022

Copy link
Copy Markdown
Member

Maybe POSIX should do something and create a portable API for this function :-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments
@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

@erlend-aaslanderlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@devnexen@erlend-aasland@bedevere-bot@vstinner@Fidget-Spinner@the-knights-who-say-ni