Skip to content

bpo-40077: Convert mmap to use heap types - #23108

Merged
vstinner merged 2 commits into
python:masterfrom
erlend-aasland:bpo-40077/mmap
Nov 3, 2020
Merged

bpo-40077: Convert mmap to use heap types#23108
vstinner merged 2 commits into
python:masterfrom
erlend-aasland:bpo-40077/mmap

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

@corona10 or @vstinner, would you mind reviewing this?

https://bugs.python.org/issue40077

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This change looks really clean and valid. But I would appreciate another review, just to double check if I missed something.

@vstinner

Copy link
Copy Markdown
Member

cc @shihai1991

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to me also ;)

@corona10
corona10 requested a review from encukouNovember 3, 2020 01:38

@shihai1991shihai1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I have no other comments in here.

@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing, all of you! 🙏🏻

@vstinner
vstinner merged commit 74b4eda into python:masterNov 3, 2020
@vstinner

Copy link
Copy Markdown
Member

One less static type! Thanks @erlend-aasland.

@erlend-aasland
erlend-aasland deleted the bpo-40077/mmap branch November 3, 2020 09:40
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL7 3.x has failed when building commit 74b4eda.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/539/builds/282) and take a look at the build logs.
  4. Check if the failure is related to this commit (74b4eda) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/539/builds/282

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

409 tests OK.

10 slowest tests:

  • test_unparse: 4 min 16 sec
  • test_concurrent_futures: 4 min 14 sec
  • test_tokenize: 3 min 33 sec
  • test_capi: 3 min 23 sec
  • test_peg_generator: 3 min 7 sec
  • test_multiprocessing_spawn: 2 min 55 sec
  • test_asyncio: 2 min 20 sec
  • test_lib2to3: 2 min 15 sec
  • test_unicodedata: 1 min 43 sec
  • test_multiprocessing_forkserver: 1 min 37 sec

1 test altered the execution environment:
test_asyncio

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 7 min 16 sec

Click to see traceback logs
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 321, in __del__self.close()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 316, in closeself._ssl_protocol._start_shutdown()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdownself._abort()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 731, in _abortself._transport.abort()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/selector_events.py", line 680, in abortself._force_close(None)
File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/selector_events.py", line 731, in _force_closeself._loop.call_soon(self._call_connection_lost, exc)
File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/base_events.py", line 746, in call_soonself._check_closed()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/base_events.py", line 510, in _check_closedraiseRuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

shihai1991 added a commit to shihai1991/cpython that referenced this pull request Nov 5, 2020
* master:
bpo-42260: Add _PyInterpreterState_SetConfig() (pythonGH-23158)
Disable peg generator tests when building with PGO (pythonGH-23141)
bpo-1635741: _sqlite3 uses PyModule_AddObjectRef() (pythonGH-23148)
bpo-1635741: Fix PyInit_pyexpat() error handling (pythonGH-22489)
bpo-42260: Main init modify sys.flags in-place (pythonGH-23150)
bpo-1635741: Fix ref leak in _PyWarnings_Init() error path (pythonGH-23151)
bpo-1635741: _ast uses PyModule_AddObjectRef() (pythonGH-23146)
bpo-1635741: _contextvars uses PyModule_AddType() (pythonGH-23147)
bpo-42260: Reorganize PyConfig (pythonGH-23149)
bpo-1635741: Add PyModule_AddObjectRef() function (pythonGH-23122)
bpo-42236: os.device_encoding() respects UTF-8 Mode (pythonGH-23119)
bpo-42251: Add gettrace and getprofile to threading (pythonGH-23125)
Enable signing of nuget.org packages and update to supported timestamp server (pythonGH-23132)
Fix incorrect links in ast docs (pythonGH-23017)
Add _PyType_GetModuleByDef (pythonGH-22835)
Post 3.10.0a2
bpo-41796: Call _PyAST_Fini() earlier to fix a leak (pythonGH-23131)
bpo-42249: Fix writing binary Plist files larger than 4 GiB. (pythonGH-23121)
bpo-40077: Convert mmap.mmap static type to a heap type (pythonGH-23108)
Python 3.10.0a2
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland@vstinner@bedevere-bot@corona10@shihai1991@the-knights-who-say-ni