Skip to content

bpo-40077: Convert arraymodule to use heap types and establish module state - #23124

Merged
encukou merged 14 commits into
python:masterfrom
erlend-aasland:bpo-40077/array
Jan 2, 2021
Merged

bpo-40077: Convert arraymodule to use heap types and establish module state#23124
encukou merged 14 commits into
python:masterfrom
erlend-aasland:bpo-40077/array

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Nov 3, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Heap types are added to a global state in preparation for module state support.

@corona10 and/or @vstinner, would you mind reviewing this?

https://bugs.python.org/issue40077

@erlend-aasland
erlend-aasland marked this pull request as draft November 3, 2020 13:33
@erlend-aasland
erlend-aasland marked this pull request as ready for review November 3, 2020 14:08
@erlend-aasland

erlend-aasland commented Nov 3, 2020

Copy link
Copy Markdown
ContributorAuthor

Ready for review, @corona10 / @vstinner!

vstinner
vstinner reviewed Nov 3, 2020
View reviewed changes
Comment threadModules/arraymodule.c Outdated
@erlend-aaslanderlend-aasland changed the title bpo-40077: Convert arraymodule to use heap types and establish a global statebpo-40077: Convert arraymodule to use heap types and establish module stateNov 3, 2020
vstinner
vstinner reviewed Nov 4, 2020
View reviewed changes
Comment threadModules/arraymodule.c Outdated
@vstinnervstinner mentioned this pull request Nov 4, 2020
Merged
@erlend-aasland

erlend-aasland commented Nov 4, 2020

Copy link
Copy Markdown
ContributorAuthor

PTAL, @vstinner. I was thinking about including migrating to PyModule_AddObjectRef as well, but I guess we can do that in a separate PR.

@github-actions

github-actionsBot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@erlend-aasland

erlend-aasland commented Dec 18, 2020

Copy link
Copy Markdown
ContributorAuthor

@vstinner Would you mind taking another look at this?

@github-actionsgithub-actionsBot removed the stale Stale PR or inactive for long period of time. label Dec 19, 2020
encukou
encukou approved these changes Dec 29, 2020
View reviewed changes

@encukouencukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have one nitpick, otherwise the change looks good! Thank you!

Comment threadModules/arraymodule.c Outdated
@erlend-aasland

erlend-aasland commented Dec 31, 2020

Copy link
Copy Markdown
ContributorAuthor

PTAL, @encukou

@encukou
encukou merged commit 75bf107 into python:masterJan 2, 2021
@erlend-aasland
erlend-aasland deleted the bpo-40077/array branch January 2, 2021 16:56
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland@adorilson
bpo-40077: Convert arraymodule to use heap types and establish module…
d595e0e
… state (pythonGH-23124)
@corona10corona10 mentioned this pull request Jun 27, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments
@encukouencukouencukou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@vstinner@encukou@the-knights-who-say-ni@bedevere-bot