Skip to content

bpo-19561: Remove unnecessary gethostname() prototype for Solaris - #23208

Closed
kulikjak wants to merge 1 commit into
python:mainfrom
kulikjak:fix-gethostname-declaration
Closed

bpo-19561: Remove unnecessary gethostname() prototype for Solaris#23208
kulikjak wants to merge 1 commit into
python:mainfrom
kulikjak:fix-gethostname-declaration

Conversation

@kulikjak

@kulikjakkulikjak commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

This is no longer necessary because Solaris included gethostname() in its header files more than 15 years ago.

https://bugs.python.org/issue19561

@jstasiakjstasiak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this on OpenIndiana, works fine.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@kulikjak

Copy link
Copy Markdown
ContributorAuthor

I cannot remove the stale label, but I am still very interested in this being merged.

@github-actionsgithub-actionsBot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@kulikjak

Copy link
Copy Markdown
ContributorAuthor

Still relevant...

@github-actionsgithub-actionsBot removed the stale Stale PR or inactive for long period of time. label Jan 17, 2021
@kulikjak
kulikjakforce-pushed the fix-gethostname-declaration branch 3 times, most recently from 3f551bd to d650b0cCompareAugust 23, 2022 12:03
@arhadthedev

Copy link
Copy Markdown
Member

@jcea (as an OpenSolaris expert)

@vstinner

vstinner commented Sep 2, 2023

Copy link
Copy Markdown
Member

I proposed PR #108817 with more details on the issue.

@kulikjak

Copy link
Copy Markdown
ContributorAuthor

Fixed with #108817.

@kulikjakkulikjak closed this Sep 3, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@kulikjak@arhadthedev@vstinner@jstasiak@the-knights-who-say-ni@ezio-melotti@bedevere-bot