Skip to content

bpo-14935: Remove static state from the _csv module - #23224

Merged
encukou merged 12 commits into
python:masterfrom
encukou:pep-573-walker-and-csv
Dec 15, 2020
Merged

bpo-14935: Remove static state from the _csv module#23224
encukou merged 12 commits into
python:masterfrom
encukou:pep-573-walker-and-csv

Conversation

@encukou

@encukouencukou commented Nov 10, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This merges code/ideas from gh-20974 and gh-16078, and uses the new _PyType_GetModuleByDef.

Co-authored-by: Marcel Plch gmarcel.plch@gmail.com
Co-authored-by: Eddie Elizondo eduardo.elizondorueda@gmail.com
Co-authored-by: Hai Shi shihai1992@gmail.com

https://bugs.python.org/issue14935

@encukouMarcel Plch
@eduardo-elizondo@shihai1991
Remove static state from the _csv module
a2a0e6f
Uses code from: python#16078
Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com>
Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
Co-authored-by: Hai Shi <shihai1992@gmail.com>
shihai1991
shihai1991 reviewed Nov 10, 2020
View reviewed changes
Comment threadModules/_csv.c Outdated
shihai1991
shihai1991 reviewed Nov 10, 2020
View reviewed changes
Comment threadModules/_csv.c
vstinner
vstinner reviewed Nov 12, 2020
View reviewed changes
Comment threadModules/_csv.c Outdated
Comment threadModules/_csv.c Outdated
Comment threadModules/_csv.c Outdated
Comment threadModules/_csv.c Outdated
Comment threadModules/_csv.c
Comment threadModules/_csv.c Outdated
Comment threadModules/_csv.c
Comment threadModules/_csv.c
vstinner
vstinner reviewed Nov 17, 2020
View reviewed changes
Comment threadModules/_csv.c Outdated
Comment threadModules/_csv.c
Comment threadModules/_csv.c
vstinner
vstinner approved these changes Dec 8, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. IMO the code is cleaner with your changes, thanks.

I just added a minor coding style remark, feel free to ignore it ;-)

Comment threadModules/_csv.c Outdated

PyType_Spec Writer_Type_spec = {
"_csv.writer",
sizeof(WriterObj),

@vstinnervstinnerDec 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use ".m_xxx = xxx" syntax here, as you did for the other spec below. Same remark for Reader_Type_spec.

vstinner
vstinner approved these changes Dec 8, 2020
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

shihai1991
shihai1991 approved these changes Dec 8, 2020
View reviewed changes

@shihai1991shihai1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no other comments, so LGTM.

@encukou
encukou merged commit 6a02b38 into python:masterDec 15, 2020
@encukou
encukou deleted the pep-573-walker-and-csv branch December 15, 2020 14:14
This was referenced Dec 15, 2020
Closed
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@encukouMarcel Plch
@eduardo-elizondo@shihai1991@adorilson
bpo-14935: Remove static state from the _csv module (pythonGH-23224)
94dc70f
Uses code from: python#16078
Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com>
Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
Co-authored-by: Hai Shi <shihai1992@gmail.com>
@erlend-aaslanderlend-aasland mentioned this pull request May 12, 2021
Merged
This was referenced May 7, 2023
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@shihai1991shihai1991shihai1991 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@encukou@vstinner@shihai1991@the-knights-who-say-ni@bedevere-bot